Skip to content

update Currently Released Plug-in section#96

Closed
mhmohona wants to merge 4 commits into
WasmEdge:mainfrom
mhmohona:currently-released-plugin
Closed

update Currently Released Plug-in section#96
mhmohona wants to merge 4 commits into
WasmEdge:mainfrom
mhmohona:currently-released-plugin

Conversation

@mhmohona
Copy link
Copy Markdown
Contributor

@mhmohona mhmohona commented Jun 8, 2023

Explanation

Update Currently Released Plug-ins section - added description in table and updated link for WASI-NN with TensorFlow-Lite backend.

Related issue

What type of PR is this

Proposed Changes

Signed-off-by: Mahfuza <mhmohona@gmail.com>
Copy link
Copy Markdown
Collaborator

alabulei1 commented Jun 8, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Overall, the changes made in the pull request for "update Currently Released Plug-in section" seem relatively minor with no identified potential problems. The main changes made include updating the table listing the currently released plug-ins to include Rust crate names, descriptions, and build steps, and adding support for PyTorch and OpenVINO backends for the WASI-NN plug-in on Ubuntu 20.04 x86_64. It may be beneficial to verify that the updated table is accurate and that the instructions for building the plug-ins are correct. Also, the patch updates the "@easyops-cn/docusaurus-search-local" package version, which may cause potential problems if it is not compatible with existing code. Therefore, it would be important to ensure that the updated package version is compatible with the existing code.

Details

Commit 6ae6fb92db7402777fda89a419e41abdea988e11

Key changes:

  • The table listing the currently released plug-ins has been updated to include Rust crate names, descriptions, and build steps.
  • PyTorch and OpenVINO backends for WASI-NN plug-in are now supported only on Ubuntu 20.04 x86_64, with plans to expand support in the future.

Potential problems:

  • There are no major issues or problems with the changes made in this pull request. However, it may be helpful to ensure that the updated table accurately reflects the current state of the plug-ins and that the instructions for building them are correct. This can be done by testing the build steps and verifying that they work as intended.

Commit dba57a35f106639c84e8856d78189fca0579e8ab

The patch updates the Currently Released Plug-in section in the intro.md file by formatting the table. It also updates the package-lock.json file by changing the version of the "@easyops-cn/docusaurus-search-local" package. Potential problems may arise if the updated package version is not compatible with the existing code.

Commit 5ba6de045ab56baf1c56a7502eae1bc48c424cf7

The key change made in this patch is the removal of a single line containing white space in the plugin intro.md document. This is a relatively minor change and does not affect the functionality of the plugin.

There are no potential problems identified in this patch.

@alabulei1
Copy link
Copy Markdown
Collaborator

Two tests failed. Please fix them.

mhmohona added 2 commits June 13, 2023 16:00
Signed-off-by: Mahfuza <mhmohona@gmail.com>
@mhmohona
Copy link
Copy Markdown
Contributor Author

Reopened another PR to pass DOC test - #107

@mhmohona mhmohona closed this Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants