Skip to content

[Testing] Use get_tests() in binaryen.js tests, so that --filter works#7483

Closed
kripken wants to merge 3 commits into
WebAssembly:mainfrom
kripken:filter.binaryenjs
Closed

[Testing] Use get_tests() in binaryen.js tests, so that --filter works#7483
kripken wants to merge 3 commits into
WebAssembly:mainfrom
kripken:filter.binaryenjs

Conversation

@kripken
Copy link
Copy Markdown
Member

@kripken kripken commented Apr 10, 2025

With this,

./check.py --binaryen-bin=... binaryenjs --filter "*debug*"

will run only the debug info test, for example.

@kripken kripken requested a review from tlively April 21, 2025 15:38
Copy link
Copy Markdown
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, not sure I knew about --filter...

@kripken
Copy link
Copy Markdown
Member Author

kripken commented Apr 21, 2025

Huh, this was fixed meanwhile by another PR (#7534)

@kripken kripken closed this Apr 21, 2025
@kripken kripken deleted the filter.binaryenjs branch April 24, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants