Fix compile errors on 2018.4.26f1#38
Merged
Merged
Conversation
Whinarn
approved these changes
Aug 25, 2020
Owner
Whinarn
left a comment
Whinarn
left a comment
There was a problem hiding this comment.
Tested this in 2018.4.26f1, 2019.3.15f1 and 2020.1.0f1 without issues.
Thank you for this fix! 👍
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 25, 2020
## [2.3.4](v2.3.3...v2.3.4) (2020-08-25) ### Bug Fixes * **tests:** compile errors on 2018.4.26f1 ([#38](#38)) ([91b5ad7](91b5ad7))
|
🎉 This PR is included in version 2.3.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions Bot
pushed a commit
to Hengle/UnityMeshSimplifier
that referenced
this pull request
Nov 18, 2023
# [2.0.0](v1.0.2...v2.0.0) (2023-11-18) ### Bug Fixes * **lod-generator-helper:** mark scene as dirty ([7554f8e](7554f8e)) * **lods:** prevent empty mesh names ([ec6cf87](ec6cf87)) * **mesh:** bug related to degenerated triangle when using smart linking ([e9d5def](e9d5def)) * **meshutils:** GetUsedUVComponents should now be able to return zero ([af60914](af60914)) * **simplifier:** obsolete properties that moved to options struct ([84664d1](84664d1)) * **simplifier:** options for uv component count ([7f7b773](7f7b773)) * **simplifier:** prevent near zero denominator ([469272a](469272a)) * **simplifier:** removed obsolete properties ([24ccc56](24ccc56)) * support Unity 2021 ([2f2eb3b](2f2eb3b)) * **tests:** compile errors on 2018.4.26f1 ([Whinarn#38](https://github.com/Hengle/UnityMeshSimplifier/issues/38)) ([91b5ad7](91b5ad7)) * **unity:** increase support for unity 2020 ([7a28614](7a28614)) ### Features * **lods:** save assets path is now less restricted ([380bda9](380bda9)) * **package:** bump minimum required version of Unity to 2018.1 ([8f37f81](8f37f81)) * **simplifier:** added options validation ([55264ce](55264ce)) * **simplifier:** set manual uv component count ([9795860](9795860)) ### Reverts * temporarily allow refactor commits to trigger a release ([fd8d697](fd8d697)) ### BREAKING CHANGES * **simplifier:** removed obsolete properties * **lods:** save assets paths are now related to Assets/ rather than Assets/UMS_LODS/
github-actions Bot
pushed a commit
to kaneleka/UnityMeshSimplifier
that referenced
this pull request
Feb 8, 2024
# [3.0.0](v2.0.1...v3.0.0) (2024-02-08) ### Bug Fixes * **lod-generator-helper:** mark scene as dirty ([7554f8e](7554f8e)) * **lods:** prevent empty mesh names ([ec6cf87](ec6cf87)) * **mesh:** bug related to degenerated triangle when using smart linking ([e9d5def](e9d5def)) * **meshutils:** GetUsedUVComponents should now be able to return zero ([af60914](af60914)) * **simplifier:** obsolete properties that moved to options struct ([84664d1](84664d1)) * **simplifier:** options for uv component count ([7f7b773](7f7b773)) * **simplifier:** prevent near zero denominator ([469272a](469272a)) * **simplifier:** removed obsolete properties ([24ccc56](24ccc56)) * support Unity 2021 ([2f2eb3b](2f2eb3b)) * **tests:** compile errors on 2018.4.26f1 ([Whinarn#38](https://github.com/kaneleka/UnityMeshSimplifier/issues/38)) ([91b5ad7](91b5ad7)) * **unity:** increase support for unity 2020 ([7a28614](7a28614)) ### Features * **lods:** save assets path is now less restricted ([380bda9](380bda9)) * **package:** bump minimum required version of Unity to 2018.1 ([8f37f81](8f37f81)) * **simplifier:** added options validation ([55264ce](55264ce)) * **simplifier:** set manual uv component count ([9795860](9795860)) ### Reverts * temporarily allow refactor commits to trigger a release ([fd8d697](fd8d697)) ### BREAKING CHANGES * **simplifier:** removed obsolete properties * **lods:** save assets paths are now related to Assets/ rather than Assets/UMS_LODS/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Somewhat related to a community contribution to Unity-Technologies/AutoLOD#74
Describe the changes
A few small fixes:
How to test
You can verify with 2018.4.26f1 by editing the manifest.json to pull the package/branch from github or clone locally to
Packages/