TIMERS: Parse all special events since pull, instead of only previous event#1
Merged
Merged
Conversation
Zidras
added a commit
that referenced
this pull request
Oct 11, 2025
… event (#1) Account for all special events on the first compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behaviour was only considering last previous special event for time difference. Some fights might depend on earlier events in the script, which were not being parsed in the TIMERS table.
One example is Professor Putricide script, where some spells from phase 2 are initiated based on an intermission cast, and not phase 2 engage.
Before:
After:
