refactor(server)!: add build_user function to DefaultContextBuilder to allow A2A user creation customization#925
Merged
guglielmo-san merged 16 commits intoa2aproject:1.0-devfrom Apr 3, 2026
Conversation
…tor_server_call_context
…ern for server request authentication
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the context building logic across gRPC, JSON-RPC, and REST adapters by introducing a centralized UserBuilder strategy and a common build_server_call_context function. This replaces the previous class-based CallContextBuilder hierarchy with a more flexible functional approach. I have included a suggestion to improve the robustness of the user_name property in StarletteUser by using getattr with a default value, which aligns with the project's coding conventions.
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/request_handlers/grpc_handler.py | 94.61% | 94.64% | 🟢 +0.03% |
| src/a2a/server/routes/jsonrpc_dispatcher.py | 86.32% | 85.23% | 🔴 -1.09% |
| src/a2a/server/routes/common.py (new) | — | 89.66% | — |
| Total | 91.91% | 91.88% | 🔴 -0.03% |
Generated by coverage-comment.yml
…nt build_user method from GrpcContextBuilder
guglielmo-san
changed the title
guglielmo-san
changed the title
ishymko
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #924 🦕