From c6a121fe62c943afdb2e2d16bfc0c4aa75e544df Mon Sep 17 00:00:00 2001 From: rajeshvelicheti Date: Thu, 28 Aug 2025 11:01:32 -0700 Subject: [PATCH 1/2] Remove logger error from init --- src/a2a/server/apps/jsonrpc/jsonrpc_app.py | 10 ---------- src/a2a/server/apps/rest/rest_adapter.py | 11 ----------- 2 files changed, 21 deletions(-) diff --git a/src/a2a/server/apps/jsonrpc/jsonrpc_app.py b/src/a2a/server/apps/jsonrpc/jsonrpc_app.py index e0b638879..65939e998 100644 --- a/src/a2a/server/apps/jsonrpc/jsonrpc_app.py +++ b/src/a2a/server/apps/jsonrpc/jsonrpc_app.py @@ -2,7 +2,6 @@ import json import logging import traceback - from abc import ABC, abstractmethod from collections.abc import AsyncGenerator, Callable from typing import TYPE_CHECKING, Any @@ -52,7 +51,6 @@ ) from a2a.utils.errors import MethodNotImplementedError - logger = logging.getLogger(__name__) if TYPE_CHECKING: @@ -219,14 +217,6 @@ def __init__( # noqa: PLR0913 extended_agent_card=extended_agent_card, extended_card_modifier=extended_card_modifier, ) - if ( - self.agent_card.supports_authenticated_extended_card - and self.extended_agent_card is None - and self.extended_card_modifier is None - ): - logger.error( - 'AgentCard.supports_authenticated_extended_card is True, but no extended_agent_card was provided. The /agent/authenticatedExtendedCard endpoint will return 404.' - ) self._context_builder = context_builder or DefaultCallContextBuilder() def _generate_error_response( diff --git a/src/a2a/server/apps/rest/rest_adapter.py b/src/a2a/server/apps/rest/rest_adapter.py index c34d10fa4..f1446af13 100644 --- a/src/a2a/server/apps/rest/rest_adapter.py +++ b/src/a2a/server/apps/rest/rest_adapter.py @@ -1,10 +1,8 @@ import functools import logging - from collections.abc import AsyncIterable, AsyncIterator, Awaitable, Callable from typing import TYPE_CHECKING, Any - if TYPE_CHECKING: from sse_starlette.sse import EventSourceResponse from starlette.requests import Request @@ -41,7 +39,6 @@ ) from a2a.utils.errors import InvalidRequestError, ServerError - logger = logging.getLogger(__name__) @@ -94,14 +91,6 @@ def __init__( # noqa: PLR0913 self.handler = RESTHandler( agent_card=agent_card, request_handler=http_handler ) - if ( - self.agent_card.supports_authenticated_extended_card - and self.extended_agent_card is None - and self.extended_card_modifier is None - ): - logger.error( - 'AgentCard.supports_authenticated_extended_card is True, but no extended_agent_card was provided. The /agent/authenticatedExtendedCard endpoint will return 404.' - ) self._context_builder = context_builder or DefaultCallContextBuilder() @rest_error_handler From 2fb4be6da303ba3cc97e7b2fcabc1d85e172d101 Mon Sep 17 00:00:00 2001 From: Holt Skinner Date: Thu, 28 Aug 2025 19:05:21 +0100 Subject: [PATCH 2/2] formatting --- src/a2a/server/apps/jsonrpc/jsonrpc_app.py | 2 ++ src/a2a/server/apps/rest/rest_adapter.py | 3 +++ 2 files changed, 5 insertions(+) diff --git a/src/a2a/server/apps/jsonrpc/jsonrpc_app.py b/src/a2a/server/apps/jsonrpc/jsonrpc_app.py index 65939e998..4f158da8e 100644 --- a/src/a2a/server/apps/jsonrpc/jsonrpc_app.py +++ b/src/a2a/server/apps/jsonrpc/jsonrpc_app.py @@ -2,6 +2,7 @@ import json import logging import traceback + from abc import ABC, abstractmethod from collections.abc import AsyncGenerator, Callable from typing import TYPE_CHECKING, Any @@ -51,6 +52,7 @@ ) from a2a.utils.errors import MethodNotImplementedError + logger = logging.getLogger(__name__) if TYPE_CHECKING: diff --git a/src/a2a/server/apps/rest/rest_adapter.py b/src/a2a/server/apps/rest/rest_adapter.py index f1446af13..40a4aacbc 100644 --- a/src/a2a/server/apps/rest/rest_adapter.py +++ b/src/a2a/server/apps/rest/rest_adapter.py @@ -1,8 +1,10 @@ import functools import logging + from collections.abc import AsyncIterable, AsyncIterator, Awaitable, Callable from typing import TYPE_CHECKING, Any + if TYPE_CHECKING: from sse_starlette.sse import EventSourceResponse from starlette.requests import Request @@ -39,6 +41,7 @@ ) from a2a.utils.errors import InvalidRequestError, ServerError + logger = logging.getLogger(__name__)