Enable reporting errors on loopvars (#376)

Author: sethvargo

.golangci.yml

@@ -33,7 +33,7 @@ linters:
     - 'bidichk'
     - 'bodyclose'
     - 'containedctx'
-    # - 'copyloopvar' TODO: enable after everything is upgraded to Go 1.22
+    - 'copyloopvar'
     - 'depguard'
     - 'dupword'
     - 'durationcheck'

cfgloader/cfgloader_test.go

@@ -114,8 +114,6 @@ num_val: 2`))},
 	}
 
 	for _, tc := range tests {
-		tc := tc
-
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 

cli/flags_test.go

@@ -663,8 +663,6 @@ func TestFlagSet_Parse(t *testing.T) {
 			"single_dash": "-",
 			"double_dash": "--",
 		} {
-			dash, dashName := dash, dashName
-
 			t.Run(dashName+"/"+tc.name, func(t *testing.T) {
 				t.Parallel()
 

healthcheck/healthcheck_test.go

@@ -84,8 +84,6 @@ func TestHandleHTTPHealth(t *testing.T) {
 
 	for _, tc := range cases {
 		for _, header := range []string{"accept", "content-type"} {
-			header := header
-
 			t.Run(tc.name+"_"+header, func(t *testing.T) {
 				t.Parallel()
 

internal/tools/terraformlinter/terraform_linter.go

@@ -106,8 +106,6 @@ func RunLinter(ctx context.Context, paths []string) error {
 
 	// Process each provided path in parallel for violations.
 	for _, path := range paths {
-		path := path
-
 		if err := pool.Do(ctx, func() ([]*ViolationInstance, error) {
 			instances, err := lint(path)
 			if err != nil {

multicloser/multicloser_test.go

@@ -84,7 +84,6 @@ func TestClose(t *testing.T) {
 
 		var c *Closer
 		for i := 0; i < 5; i++ {
-			i := i
 			c = Append(c, func() error {
 				return fmt.Errorf("%d", i)
 			})

workerpool/workerpool_test.go

@@ -101,8 +101,6 @@ func TestWorker_Done(t *testing.T) {
 		})
 
 		for i := 0; i < 5; i++ {
-			i := i
-
 			if err := pool.Do(ctx, func() (*Void, error) {
 				time.Sleep(time.Duration(i) * time.Millisecond)
 				return nil, fmt.Errorf("%d", i)
@@ -137,8 +135,6 @@ func TestWorker_Done(t *testing.T) {
 		})
 
 		for i := 0; i < 5; i++ {
-			i := i
-
 			if err := pool.Do(ctx, func() (int, error) {
 				time.Sleep(time.Duration(i) * time.Millisecond)
 				return i, nil
@@ -173,8 +169,6 @@ func TestWorker_Done(t *testing.T) {
 		})
 
 		for i := 0; i < 5; i++ {
-			i := i
-
 			_ = pool.Do(ctx, func() (int, error) {
 				if i < 2 {
 					return i, nil
@@ -218,8 +212,6 @@ func TestWorker_Done(t *testing.T) {
 		})
 
 		for i := 0; i < 5; i++ {
-			i := i
-
 			err := pool.Do(ctx, func() (int, error) {
 				time.Sleep(100 * time.Millisecond)
 				return i, nil
@@ -266,7 +258,6 @@ func TestWorker_Done(t *testing.T) {
 		var wg sync.WaitGroup
 
 		for i := 0; i < 15; i++ {
-			i := i
 			wg.Add(1)
 
 			go func() {