Update: core package ably/cli prod dependencies#253
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
356cd6f to
337cb4d
Compare
ably/cli prod dependencies to latest version
ably/cli prod dependencies to latest versionably/cli prod dependencies
|
Walkthrough: This PR updates nine core production dependencies of @ably/cli to their latest versions, addressing two open Dependabot PRs. Changes confined to package.json and pnpm-lock.yaml only. Review Notes: (1) Major version bump open v10 to v11 - verify API surface unchanged. (2) @ably/spaces v0.4 to v0.5 - check commands in src/commands/spaces/ against Spaces changelog. (3) @oclif/core v4.2 to v4.10 - flag parsing/help rendering may subtly change, run pnpm test:unit and smoke-test --help. (4) No source code changes - no test updates for behavioral differences. (5) E2E tests required before merging. |
Walkthrough |
ably/cli prod dependenciesably/cli prod dependencies
There was a problem hiding this comment.
Review: Dependency updates PR
This is a clean dependency bump PR. I reviewed each upgrade for breaking changes, API compatibility, and runtime requirements. Here's what I found:
open v10.1.0 → v11.0.0 (Major bump) ✅
The only breaking change in v11 is raising the minimum Node.js requirement from 18 to 20. Since this project already requires node >=22.0.0 (per package.json engines field), this is a non-issue.
The API usage in src/utils/open-url.ts and src/commands/accounts/login.ts:
import open from "open";
await open(url);…is identical in v10 and v11. No code changes needed.
@ably/spaces v0.4.0 → v0.5.2 (Minor) ✅
No breaking changes between 0.4.x and 0.5.x. Notable internal changes in 0.5.0 that don't affect this codebase:
outboundBatchIntervaldefault changed from 25ms → 50ms (CLI doesn't use this option)space.connectionIdconverted from a field to a getter (CLI readsconnectionIdfrom member objects, not the Space directly)
@oclif/core v4.2.10 → v4.10.3 (Minor — large jump) ⚠️
No breaking API changes. However, two behavioral changes will affect help output and thus the README:
-
v4.5.6: Optional (non-required) args now display as
[ARG_NAME]in ARGUMENTS sections and USAGE lines. Several CLI commands have optional args (accounts login,accounts switch,apps delete, etc.) and their help text will change. -
v4.8.0: Flags with
env:now show[env: VAR_NAME]in--helpoutput. This affects--control-host,--dashboard-host, and--appflags.
The PR checklist doesn't include pnpm exec oclif readme (step 2 of the mandatory workflow). After merging, the README.md will be out of sync with actual help output until regenerated. The PR description says "pnpm prepare succeeds" but that's separate from oclif readme.
Suggest adding pnpm exec oclif readme to the test plan and committing the resulting README changes, or verifying it's already part of pnpm prepare in this project.
Other upgrades ✅
ablyv2.19 → v2.21: Minor SDK bump, no API changes affecting CLI commandswsv8.16 → v8.20: Patch-level bug fixes within v8@oclif/plugin-autocomplete,@oclif/plugin-warn-if-update-available: Patch bumps, no impact@xterm/addon-fit,@xterm/addon-web-links: Minor bumps, purely additive (xterm peer dep qualifier disappearing from lockfile is a pnpm format change, not a version issue)
Summary
The upgrades are safe and no code changes are required. The one thing to address before merging is the README regeneration — run pnpm exec oclif readme and commit the diff so the README reflects the new [ARG_NAME] and [env: VAR_NAME] formatting that @oclif/core 4.10 will produce.
WalkthroughThis PR updates all core production dependencies of Changes
Review Notes
|
Summary
Updates all core production dependencies of
@ably/clito their latest versions.Dependency Updates
@ably/spaces@oclif/core@oclif/plugin-autocomplete@oclif/plugin-warn-if-update-available@xterm/addon-fit@xterm/addon-web-linksablyopenwsTest plan
pnpm preparesucceedspnpm test:unitpassespnpm exec eslint .shows 0 errors