Skip to content

Commit fac028d

Browse files
committed
Further cleanup
1 parent 741f3bb commit fac028d

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/main/java/org/assertj/core/api/ComparatorFactory.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ public class ComparatorFactory {
2020

2121
public static final ComparatorFactory INSTANCE = new ComparatorFactory();
2222

23-
public Comparator<Double> doubleComparatorWithPrecision(final double precision) {
24-
@SuppressWarnings("unused") // can't use <> with anonymous class in java 8
25-
Comparator<Double> closeToComparator = new Comparator<Double>() {
23+
public Comparator<Double> doubleComparatorWithPrecision(double precision) {
24+
// can't use <> with anonymous class in java 8
25+
return new Comparator<Double>() {
2626
@Override
2727
public int compare(Double o1, Double o2) {
2828
if (abs(o1 - o2) < precision) return 0;
@@ -34,15 +34,14 @@ public String toString() {
3434
return "double comparator at precision " + precision;
3535
}
3636
};
37-
return closeToComparator;
3837
}
3938

40-
public Comparator<Float> floatComparatorWithPrecision(final float precision) {
41-
@SuppressWarnings("unused")
42-
Comparator<Float> closeToComparator = new Comparator<Float>() {
39+
public Comparator<Float> floatComparatorWithPrecision(float precision) {
40+
// can't use <> with anonymous class in java 8
41+
return new Comparator<Float>() {
4342
@Override
4443
public int compare(Float o1, Float o2) {
45-
if(abs(o1 - o2) < precision) return 0;
44+
if (abs(o1 - o2) < precision) return 0;
4645
return o1 - o2 > 0 ? 1 : -1;
4746
}
4847

@@ -51,6 +50,6 @@ public String toString() {
5150
return "float comparator at precision " + precision;
5251
}
5352
};
54-
return closeToComparator;
5553
}
54+
5655
}

0 commit comments

Comments
 (0)