From 4a7d3454df9451b282f54de8bc93759e9ea13e22 Mon Sep 17 00:00:00 2001 From: TingluoHuang Date: Thu, 18 Aug 2022 22:21:09 -0400 Subject: [PATCH 1/2] Include step context name in telemetry. --- src/Runner.Worker/ExecutionContext.cs | 1 + src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs | 3 +++ 2 files changed, 4 insertions(+) diff --git a/src/Runner.Worker/ExecutionContext.cs b/src/Runner.Worker/ExecutionContext.cs index 4b63b15bcf4..19b6e0a61d3 100644 --- a/src/Runner.Worker/ExecutionContext.cs +++ b/src/Runner.Worker/ExecutionContext.cs @@ -369,6 +369,7 @@ public IExecutionContext CreateChild( child.StepTelemetry.StepId = recordId; child.StepTelemetry.Stage = stage.ToString(); child.StepTelemetry.IsEmbedded = isEmbedded; + child.StepTelemetry.StepContextName = child.GetFullyQualifiedContextName();; return child; } diff --git a/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs b/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs index 71384013922..a0685ff6f57 100644 --- a/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs +++ b/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs @@ -30,6 +30,9 @@ public ActionsStepTelemetry() [DataMember(EmitDefaultValue = false)] public Guid StepId { get; set; } + [DataMember(EmitDefaultValue = false)] + public string StepContextName { get; set; } + [DataMember(EmitDefaultValue = false)] public bool? HasRunsStep { get; set; } From 6b9153231f0b2fb0f35ab7e3c29b174384a8d6d4 Mon Sep 17 00:00:00 2001 From: TingluoHuang Date: Fri, 19 Aug 2022 09:29:04 -0400 Subject: [PATCH 2/2] . --- src/Runner.Worker/ExecutionContext.cs | 4 +++- src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/src/Runner.Worker/ExecutionContext.cs b/src/Runner.Worker/ExecutionContext.cs index 19b6e0a61d3..1152f5845cf 100644 --- a/src/Runner.Worker/ExecutionContext.cs +++ b/src/Runner.Worker/ExecutionContext.cs @@ -369,7 +369,7 @@ public IExecutionContext CreateChild( child.StepTelemetry.StepId = recordId; child.StepTelemetry.Stage = stage.ToString(); child.StepTelemetry.IsEmbedded = isEmbedded; - child.StepTelemetry.StepContextName = child.GetFullyQualifiedContextName();; + child.StepTelemetry.StepContextName = child.GetFullyQualifiedContextName(); ; return child; } @@ -960,6 +960,8 @@ public void PublishStepTelemetry() _record.StartTime != null) { StepTelemetry.ExecutionTimeInSeconds = (int)Math.Ceiling((_record.FinishTime - _record.StartTime)?.TotalSeconds ?? 0); + StepTelemetry.StartTime = _record.StartTime; + StepTelemetry.FinishTime = _record.FinishTime; } if (!IsEmbedded && diff --git a/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs b/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs index a0685ff6f57..e6ee7f6472a 100644 --- a/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs +++ b/src/Sdk/DTWebApi/WebApi/ActionsStepTelemetry.cs @@ -60,6 +60,12 @@ public ActionsStepTelemetry() [DataMember(EmitDefaultValue = false)] public int? ExecutionTimeInSeconds { get; set; } + [DataMember(EmitDefaultValue = false)] + public DateTime? StartTime { get; set; } + + [DataMember(EmitDefaultValue = false)] + public DateTime? FinishTime { get; set; } + [DataMember(EmitDefaultValue = false)] public string ContainerHookData { get; set; } }