From f9a2b4d711c0beaea6accfc56914e5dca4290bc4 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 13:10:49 +0200 Subject: [PATCH 01/10] Update README --- README.md | 60 ++++++++++++++++++++++++++++++++++++++++++++++++------- 1 file changed, 53 insertions(+), 7 deletions(-) diff --git a/README.md b/README.md index 3853e8148..cc45f2a55 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,9 @@ This action sets up a Python environment for use in actions by: -- optionally installing a version of Python and adding to PATH. Note that this action only uses versions of Python already installed in the cache. The action will fail if no matching versions are found. +- optionally installing and adding to PATH a version of Python that is already installed in the tools cache +- downloading, installing and adding to PATH an available version of Python from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) if a specific version is not available in the tools cache +- failing if a specific version of Python is not preinstalled or available for download - registering problem matchers for error output # Usage @@ -67,13 +69,41 @@ jobs: run: python -c "import sys; print(sys.version)" ``` +Download and setup a version of Python that does not come pre-installed on an image: +```yaml +jobs: + build: + runs-on: ubuntu-latest + strategy: + python-version: [3.5.4, 3.6.6, 3.7.4, 3.8.1] + steps: + - uses: actions/checkout@v2 + - uses: actions/setup-python@v1 + with: + python-version: ${{ matrix.python }} + - run: python my_script.py + +``` + # Getting started with Python + Actions Check out our detailed guide on using [Python with GitHub Actions](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/using-python-with-github-actions). +# Available versions of Python + +`setup-python` is able to configure python from two sources + +- Preinstalled versions of Python in the tools cache on GitHub-hosted runners + - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners) + - For every minor version of Python, expect only the latest patch to be preinstalled. See [Semantic Versioning](https://semver.org/) for more information + - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache +- Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) + - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file + - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository + # Hosted Tool Cache -GitHub hosted runners have a tools cache that comes with Python + PyPy already installed. This tools cache helps speed up runs and tool setup by not requiring any new downloads. There is an environment variable called `RUNNER_TOOL_CACHE` on each runner that describes the location of this tools cache and there is where you will find Python and PyPy installed. `setup-python` works by taking a specific version of Python or PyPy in this tools cache and adding it to PATH. +GitHub hosted runners have a tools cache that comes with a few versions of Python + PyPy already installed. This tools cache helps speed up runs and tool setup by not requiring any new downloads. There is an environment variable called `RUNNER_TOOL_CACHE` on each runner that describes the location of this tools cache and there is where you will find Python and PyPy installed. `setup-python` works by taking a specific version of Python or PyPy in this tools cache and adding it to PATH. || Location | |------|-------| @@ -87,9 +117,18 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// # Using `setup-python` with a self hosted runner -If you would like to use `setup-python` on a self-hosted runner, you will need to download all versions of Python & PyPy that you would like and setup a similar tools cache locally for your runner. +If you would like to use `setup-python` and a self-hosted runner, you have two options + - Setup a tools cache locally and download all the versions of Python & PyPy that you would like once + - Takes a little bit to time to initially setup + - This will be the most stable and fastest option long-term as it will require no extra downloads every-time there is a run + - Download and setup a version of python every-time + - Requires no extra setup (good if you want to quickly get up and running, discouraged for long term use) + - `setup-python` will take a little longer to run + - Note: when downloading versions of Python for Windows, an MSI installer is used which can modify some registry settings -- Create an global environment variable called `AGENT_TOOLSDIRECTORY` that will point to the root directory of where you want the tools installed. The env variable is preferrably global as it must be set in the shell that will install the tools cache, along with the shell that the runner will be using. +### Setting up a local tools cache + +- Create an global environment variable called `AGENT_TOOLSDIRECTORY` that will point to the root directory of where you want the tools installed. The env variable is preferably global as it must be set in the shell that will install the tools cache, along with the shell that the runner will be using. - This env variable is used internally by the runner to set the `RUNNER_TOOL_CACHE` env variable - Example for Administrator Powershell: `[System.Environment]::SetEnvironmentVariable("AGENT_TOOLSDIRECTORY", "C:\hostedtoolcache\windows", [System.EnvironmentVariableTarget]::Machine)` (restart the shell afterwards) - Download the appropriate NPM packages from the [GitHub Actions NPM registry](https://github.com/orgs/actions/packages) @@ -106,9 +145,16 @@ If you would like to use `setup-python` on a self-hosted runner, you will need t `setup-python` helps keep your dependencies explicit and ensures consistent behavior between different runners. If you use `python` in a shell on a GitHub hosted runner without `setup-python` it will default to whatever is in PATH. The default version of Python in PATH vary between runners and can change unexpectedly so we recommend you always use `setup-python`. -# Available versions of Python +# Need to open an issue? + +Python versions that we compile and setup can be found in the [actions/python-versions](https://github.com/actions/python-versions) repository. You can see the build scripts, configurations, and everything that is used. You should open an issue in the `python-versions` repository if: + - something might be compiled incorrectly + - certain modules might be missing + - there is a version of Python that you would like that is currently not available + +If you suspect something might be wrong with the tools cache or how Python gets installed on GitHub hosted runners, please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments) -For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners) +Any remaining issues can be filed in this repository # License @@ -116,4 +162,4 @@ The scripts and documentation in this project are released under the [MIT Licens # Contributions -Contributions are welcome! See [Contributor's Guide](docs/contributors.md) +Contributions are welcome! See our [Contributor's Guide](docs/contributors.md) From ea04f3970907b98d0f22b9a372380f89385b46d7 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 13:56:43 +0200 Subject: [PATCH 02/10] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index cc45f2a55..751682f86 100644 --- a/README.md +++ b/README.md @@ -91,7 +91,7 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. # Available versions of Python -`setup-python` is able to configure python from two sources +`setup-python` is able to configure Python from two sources - Preinstalled versions of Python in the tools cache on GitHub-hosted runners - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners) From c3c0c30edab7d588b7a0118331444de348eef91a Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 13:57:20 +0200 Subject: [PATCH 03/10] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 751682f86..8035c31c7 100644 --- a/README.md +++ b/README.md @@ -119,7 +119,7 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// If you would like to use `setup-python` and a self-hosted runner, you have two options - Setup a tools cache locally and download all the versions of Python & PyPy that you would like once - - Takes a little bit to time to initially setup + - Takes a little bit of time to initially setup - This will be the most stable and fastest option long-term as it will require no extra downloads every-time there is a run - Download and setup a version of python every-time - Requires no extra setup (good if you want to quickly get up and running, discouraged for long term use) From 8b9b081ff72ac0041f89572265e6a311042f423c Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 15:08:29 +0200 Subject: [PATCH 04/10] Apply suggestions from code review Co-Authored-By: Brian Cristante <33549821+brcrista@users.noreply.github.com> --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 8035c31c7..f4a4a0a37 100644 --- a/README.md +++ b/README.md @@ -91,10 +91,10 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. # Available versions of Python -`setup-python` is able to configure Python from two sources +`setup-python` is able to configure Python from two sources: - Preinstalled versions of Python in the tools cache on GitHub-hosted runners - - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners) + - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners). - For every minor version of Python, expect only the latest patch to be preinstalled. See [Semantic Versioning](https://semver.org/) for more information - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache - Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) @@ -147,14 +147,14 @@ If you would like to use `setup-python` and a self-hosted runner, you have two o # Need to open an issue? -Python versions that we compile and setup can be found in the [actions/python-versions](https://github.com/actions/python-versions) repository. You can see the build scripts, configurations, and everything that is used. You should open an issue in the `python-versions` repository if: +Python versions available for `setup-python` can be found in the [actions/python-versions](https://github.com/actions/python-versions) repository. You can see the build scripts, configurations, and everything that is used. You should open an issue in the `python-versions` repository if: - something might be compiled incorrectly - certain modules might be missing - there is a version of Python that you would like that is currently not available -If you suspect something might be wrong with the tools cache or how Python gets installed on GitHub hosted runners, please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments) +If you suspect something might be wrong with the tools cache or how Python gets installed on GitHub hosted runners, please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments). -Any remaining issues can be filed in this repository +Any remaining issues can be filed in this repository. # License From 55306a552e9a92a3bac6eac208bf18cedcea1fd9 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 15:54:54 +0200 Subject: [PATCH 05/10] Update README.md Co-Authored-By: Brian Cristante <33549821+brcrista@users.noreply.github.com> --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f4a4a0a37..27ddf5245 100644 --- a/README.md +++ b/README.md @@ -75,7 +75,7 @@ jobs: build: runs-on: ubuntu-latest strategy: - python-version: [3.5.4, 3.6.6, 3.7.4, 3.8.1] + python-version: [3.5, 3.6, 3.7.4, 3.8] steps: - uses: actions/checkout@v2 - uses: actions/setup-python@v1 From c0bcb3dafe70281437021eaed5e0d899c4e5663a Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 17:39:45 +0200 Subject: [PATCH 06/10] Update self hosted instructions --- README.md | 35 +++++++++-------------------------- 1 file changed, 9 insertions(+), 26 deletions(-) diff --git a/README.md b/README.md index cc45f2a55..764844a13 100644 --- a/README.md +++ b/README.md @@ -69,7 +69,7 @@ jobs: run: python -c "import sys; print(sys.version)" ``` -Download and setup a version of Python that does not come pre-installed on an image: +Download and set up a version of Python that does not come preinstalled on an image: ```yaml jobs: build: @@ -97,6 +97,7 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners) - For every minor version of Python, expect only the latest patch to be preinstalled. See [Semantic Versioning](https://semver.org/) for more information - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache + - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In this case, for example, the version spec 3.8 will use the 3.8.2 found in the cache - Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository @@ -117,29 +118,13 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// # Using `setup-python` with a self hosted runner -If you would like to use `setup-python` and a self-hosted runner, you have two options - - Setup a tools cache locally and download all the versions of Python & PyPy that you would like once - - Takes a little bit to time to initially setup - - This will be the most stable and fastest option long-term as it will require no extra downloads every-time there is a run - - Download and setup a version of python every-time - - Requires no extra setup (good if you want to quickly get up and running, discouraged for long term use) - - `setup-python` will take a little longer to run - - Note: when downloading versions of Python for Windows, an MSI installer is used which can modify some registry settings - -### Setting up a local tools cache - -- Create an global environment variable called `AGENT_TOOLSDIRECTORY` that will point to the root directory of where you want the tools installed. The env variable is preferably global as it must be set in the shell that will install the tools cache, along with the shell that the runner will be using. - - This env variable is used internally by the runner to set the `RUNNER_TOOL_CACHE` env variable - - Example for Administrator Powershell: `[System.Environment]::SetEnvironmentVariable("AGENT_TOOLSDIRECTORY", "C:\hostedtoolcache\windows", [System.EnvironmentVariableTarget]::Machine)` (restart the shell afterwards) -- Download the appropriate NPM packages from the [GitHub Actions NPM registry](https://github.com/orgs/actions/packages) - - Make sure to have `npm` installed, and then [configure npm for use with GitHub packages](https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages#authenticating-to-github-package-registry) - - Create an empty npm project for easier installation (`npm init`) in the tools cache directory. You can delete `package.json`, `package.lock.json` and `node_modules` after all tools get installed - - Before downloading a specific package, create an empty folder for the version of Python/PyPY that is being installed. If downloading Python 3.6.8 for example, create `C:\hostedtoolcache\windows\Python\3.6.8` - - Once configured, download a specific package by calling `npm install`. Note (if downloading a PyPy package on Windows, you will need 7zip installed along with `7z.exe` added to your PATH) -- Each NPM package has multiple versions that determine the version of Python or PyPy that should be installed. - - `npm install @actions/toolcache-python-windows-x64@3.7.61579791175` for example installs Python 3.7.6 while `npm install @actions/toolcache-python-windows-x64@3.6.81579791177` installs Python 3.6.8 - - You can browse and find all available versions of a package by searching the GitHub Actions NPM registry -![image](https://user-images.githubusercontent.com/16109154/76194005-87aeb400-61e5-11ea-9b21-ef9111247f84.png) +If you would like to use `setup-python` and a self-hosted runner, there isn't much that you need to do. When `setup-python` is run for the first time with a version of Python that it doesn't have, it will download the appropriate version, and setup the tools cache on your machine. Any subsequent runs will use the python versions that were previously downloaded. + +A few things to look out for when `setup-python` is first setting up the tools cache +- If using Windows, your runner needs to be running as an administrator so that the appropriate directories and files can be setup. On Linux and Mac, you also need to be running with elevated permissions +- On Windows, you need `7zip` installed and added to your `PATH` so that files can be extracted properly during setup +- MSI installers are used when setting up Python on Windows. A word of caution as MSI installers update registry settings +- The 3.8 MSI installer for Windows will not let you install another 3.8 version of Python. If `setup-python` fails for a 3.8 version of Python, make sure any previously installed versions are removed by going to "Apps and Features" in the Windows settings and uninstalling any # Using Python without `setup-python` @@ -152,8 +137,6 @@ Python versions that we compile and setup can be found in the [actions/python-ve - certain modules might be missing - there is a version of Python that you would like that is currently not available -If you suspect something might be wrong with the tools cache or how Python gets installed on GitHub hosted runners, please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments) - Any remaining issues can be filed in this repository # License From 155f54e8c449ac79d8c0dbf027922410bb097921 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 18:21:26 +0200 Subject: [PATCH 07/10] Clarifications around the Python version --- README.md | 49 +++++++++++++++---------------------------------- 1 file changed, 15 insertions(+), 34 deletions(-) diff --git a/README.md b/README.md index 0c5e5378e..7a3bfa18c 100644 --- a/README.md +++ b/README.md @@ -75,6 +75,7 @@ jobs: build: runs-on: ubuntu-latest strategy: + # in this example, there is a newer version already installed, 3.7.7, so the older version will be downloaded python-version: [3.5, 3.6, 3.7.4, 3.8] steps: - uses: actions/checkout@v2 @@ -95,9 +96,9 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. - Preinstalled versions of Python in the tools cache on GitHub-hosted runners - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners). - - For every minor version of Python, expect only the latest patch to be preinstalled. See [Semantic Versioning](https://semver.org/) for more information + - For every minor version of Python, expect only the latest patch to be preinstalled - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache - - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In this case, for example, the version spec 3.8 will use the 3.8.2 found in the cache + - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In the previous example, the version spec 3.8 will use the 3.8.2 python version found in the cache - Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository @@ -116,9 +117,20 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// - [Tools cache setup for Ubuntu](https://github.com/actions/virtual-environments/blob/master/images/linux/scripts/installers/hosted-tool-cache.sh) - [Tools cache setup for Windows](https://github.com/actions/virtual-environments/blob/master/images/win/scripts/Installers/Download-ToolCache.ps1) +# Specifying a python version + +If there is a specific version of Python that you need and you don't want to worry about any potential breaking changes due to patch updates (going from `3.7.5` to `3.7.6` for example), you should specify the exact major, minor, and patch version (such as `3.7.5`) + - The only downside to this is that setup will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions + - MSI installers are used on Windows for this, so runs will take a little longer to setup vs Mac and Linux + +You should specify only a major and minor version if you are okay with the most recent patch version being used + - For example, if you just want a `3.8` version of Python, and it doesn't matter if `3.8.1` is used or the more recent `3.8.2`, + - There will be a single patch version already installed on each runner for every minor version of Python that is supported + - The patch version that will be preinstalled, will generally be the latest and every time there is a new patch released, the older version that is preinstalled will be replaced + - Using the most recent patch version will result in a very quick setup since no downloads will be required since a locally installed version Python on the runner will be used + # Using `setup-python` with a self hosted runner -<<<<<<< HEAD If you would like to use `setup-python` and a self-hosted runner, there isn't much that you need to do. When `setup-python` is run for the first time with a version of Python that it doesn't have, it will download the appropriate version, and setup the tools cache on your machine. Any subsequent runs will use the python versions that were previously downloaded. A few things to look out for when `setup-python` is first setting up the tools cache @@ -126,31 +138,6 @@ A few things to look out for when `setup-python` is first setting up the tools c - On Windows, you need `7zip` installed and added to your `PATH` so that files can be extracted properly during setup - MSI installers are used when setting up Python on Windows. A word of caution as MSI installers update registry settings - The 3.8 MSI installer for Windows will not let you install another 3.8 version of Python. If `setup-python` fails for a 3.8 version of Python, make sure any previously installed versions are removed by going to "Apps and Features" in the Windows settings and uninstalling any -======= -If you would like to use `setup-python` and a self-hosted runner, you have two options - - Setup a tools cache locally and download all the versions of Python & PyPy that you would like once - - Takes a little bit of time to initially setup - - This will be the most stable and fastest option long-term as it will require no extra downloads every-time there is a run - - Download and setup a version of python every-time - - Requires no extra setup (good if you want to quickly get up and running, discouraged for long term use) - - `setup-python` will take a little longer to run - - Note: when downloading versions of Python for Windows, an MSI installer is used which can modify some registry settings - -### Setting up a local tools cache - -- Create an global environment variable called `AGENT_TOOLSDIRECTORY` that will point to the root directory of where you want the tools installed. The env variable is preferably global as it must be set in the shell that will install the tools cache, along with the shell that the runner will be using. - - This env variable is used internally by the runner to set the `RUNNER_TOOL_CACHE` env variable - - Example for Administrator Powershell: `[System.Environment]::SetEnvironmentVariable("AGENT_TOOLSDIRECTORY", "C:\hostedtoolcache\windows", [System.EnvironmentVariableTarget]::Machine)` (restart the shell afterwards) -- Download the appropriate NPM packages from the [GitHub Actions NPM registry](https://github.com/orgs/actions/packages) - - Make sure to have `npm` installed, and then [configure npm for use with GitHub packages](https://help.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-npm-for-use-with-github-packages#authenticating-to-github-package-registry) - - Create an empty npm project for easier installation (`npm init`) in the tools cache directory. You can delete `package.json`, `package.lock.json` and `node_modules` after all tools get installed - - Before downloading a specific package, create an empty folder for the version of Python/PyPY that is being installed. If downloading Python 3.6.8 for example, create `C:\hostedtoolcache\windows\Python\3.6.8` - - Once configured, download a specific package by calling `npm install`. Note (if downloading a PyPy package on Windows, you will need 7zip installed along with `7z.exe` added to your PATH) -- Each NPM package has multiple versions that determine the version of Python or PyPy that should be installed. - - `npm install @actions/toolcache-python-windows-x64@3.7.61579791175` for example installs Python 3.7.6 while `npm install @actions/toolcache-python-windows-x64@3.6.81579791177` installs Python 3.6.8 - - You can browse and find all available versions of a package by searching the GitHub Actions NPM registry -![image](https://user-images.githubusercontent.com/16109154/76194005-87aeb400-61e5-11ea-9b21-ef9111247f84.png) ->>>>>>> 55306a552e9a92a3bac6eac208bf18cedcea1fd9 # Using Python without `setup-python` @@ -163,13 +150,7 @@ Python versions available for `setup-python` can be found in the [actions/python - certain modules might be missing - there is a version of Python that you would like that is currently not available -<<<<<<< HEAD Any remaining issues can be filed in this repository -======= -If you suspect something might be wrong with the tools cache or how Python gets installed on GitHub hosted runners, please open an issue in [actions/virtual-environments](https://github.com/actions/virtual-environments). - -Any remaining issues can be filed in this repository. ->>>>>>> 55306a552e9a92a3bac6eac208bf18cedcea1fd9 # License From f76bff268f8bda3f5a6b676e3f4f4c28ca006f50 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 18:22:07 +0200 Subject: [PATCH 08/10] Minor Fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 7a3bfa18c..162bc5e4b 100644 --- a/README.md +++ b/README.md @@ -117,7 +117,7 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// - [Tools cache setup for Ubuntu](https://github.com/actions/virtual-environments/blob/master/images/linux/scripts/installers/hosted-tool-cache.sh) - [Tools cache setup for Windows](https://github.com/actions/virtual-environments/blob/master/images/win/scripts/Installers/Download-ToolCache.ps1) -# Specifying a python version +# Specifying a Python version If there is a specific version of Python that you need and you don't want to worry about any potential breaking changes due to patch updates (going from `3.7.5` to `3.7.6` for example), you should specify the exact major, minor, and patch version (such as `3.7.5`) - The only downside to this is that setup will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions From 0b4e3009758b1cba74e17ab33a585b9f8b3c710f Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 18:54:46 +0200 Subject: [PATCH 09/10] Apply suggestions from code review Co-Authored-By: Brian Cristante <33549821+brcrista@users.noreply.github.com> --- README.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 162bc5e4b..ecca39a16 100644 --- a/README.md +++ b/README.md @@ -98,7 +98,7 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners). - For every minor version of Python, expect only the latest patch to be preinstalled - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache - - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In the previous example, the version spec 3.8 will use the 3.8.2 python version found in the cache + - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In the previous example, the version spec `3.8` will use the `3.8.2` Python version found in the cache - Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository @@ -120,8 +120,8 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// # Specifying a Python version If there is a specific version of Python that you need and you don't want to worry about any potential breaking changes due to patch updates (going from `3.7.5` to `3.7.6` for example), you should specify the exact major, minor, and patch version (such as `3.7.5`) - - The only downside to this is that setup will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions - - MSI installers are used on Windows for this, so runs will take a little longer to setup vs Mac and Linux + - The only downside to this is that set up will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions + - MSI installers are used on Windows for this, so runs will take a little longer to set up vs Mac and Linux You should specify only a major and minor version if you are okay with the most recent patch version being used - For example, if you just want a `3.8` version of Python, and it doesn't matter if `3.8.1` is used or the more recent `3.8.2`, @@ -131,13 +131,13 @@ You should specify only a major and minor version if you are okay with the most # Using `setup-python` with a self hosted runner -If you would like to use `setup-python` and a self-hosted runner, there isn't much that you need to do. When `setup-python` is run for the first time with a version of Python that it doesn't have, it will download the appropriate version, and setup the tools cache on your machine. Any subsequent runs will use the python versions that were previously downloaded. +If you would like to use `setup-python` and a self-hosted runner, there isn't much that you need to do. When `setup-python` is run for the first time with a version of Python that it doesn't have, it will download the appropriate version, and set up the tools cache on your machine. Any subsequent runs will use the Python versions that were previously downloaded. A few things to look out for when `setup-python` is first setting up the tools cache - If using Windows, your runner needs to be running as an administrator so that the appropriate directories and files can be setup. On Linux and Mac, you also need to be running with elevated permissions - On Windows, you need `7zip` installed and added to your `PATH` so that files can be extracted properly during setup - MSI installers are used when setting up Python on Windows. A word of caution as MSI installers update registry settings -- The 3.8 MSI installer for Windows will not let you install another 3.8 version of Python. If `setup-python` fails for a 3.8 version of Python, make sure any previously installed versions are removed by going to "Apps and Features" in the Windows settings and uninstalling any +- The 3.8 MSI installer for Windows will not let you install another 3.8 version of Python. If `setup-python` fails for a 3.8 version of Python, make sure any previously installed versions are removed by going to "Apps & Features" in the Settings app. # Using Python without `setup-python` From 5879e5a4296cbd7efe7143d20bff3af8d1629492 Mon Sep 17 00:00:00 2001 From: Konrad Pabjan Date: Wed, 29 Apr 2020 19:01:40 +0200 Subject: [PATCH 10/10] PR Feedback --- README.md | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/README.md b/README.md index ecca39a16..2887c751e 100644 --- a/README.md +++ b/README.md @@ -96,12 +96,12 @@ Check out our detailed guide on using [Python with GitHub Actions](https://help. - Preinstalled versions of Python in the tools cache on GitHub-hosted runners - For detailed information regarding the available versions of Python that are installed see [Software installed on GitHub-hosted runners](https://help.github.com/en/actions/automating-your-workflow-with-github-actions/software-installed-on-github-hosted-runners). - - For every minor version of Python, expect only the latest patch to be preinstalled - - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache - - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In the previous example, the version spec `3.8` will use the `3.8.2` Python version found in the cache + - For every minor version of Python, expect only the latest patch to be preinstalled. + - If `3.8.1` is installed for example, and `3.8.2` is released, expect `3.8.1` to be removed and replaced by `3.8.2` in the tools cache. + - If the exact patch version doesn't matter to you, specifying just the major and minor version will get you the latest preinstalled patch version. In the previous example, the version spec `3.8` will use the `3.8.2` Python version found in the cache. - Downloadable Python versions from GitHub Releases ([actions/python-versions](https://github.com/actions/python-versions/releases)) - - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file - - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository + - All available versions are listed in the [version-manifest.json](https://github.com/actions/python-versions/blob/master/versions-manifest.json) file. + - If there is a specific version of Python that is not available, you can open an issue in the `python-versions` repository. # Hosted Tool Cache @@ -120,14 +120,13 @@ GitHub virtual environments are setup in [actions/virtual-environments](https:// # Specifying a Python version If there is a specific version of Python that you need and you don't want to worry about any potential breaking changes due to patch updates (going from `3.7.5` to `3.7.6` for example), you should specify the exact major, minor, and patch version (such as `3.7.5`) - - The only downside to this is that set up will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions - - MSI installers are used on Windows for this, so runs will take a little longer to set up vs Mac and Linux - -You should specify only a major and minor version if you are okay with the most recent patch version being used - - For example, if you just want a `3.8` version of Python, and it doesn't matter if `3.8.1` is used or the more recent `3.8.2`, - - There will be a single patch version already installed on each runner for every minor version of Python that is supported - - The patch version that will be preinstalled, will generally be the latest and every time there is a new patch released, the older version that is preinstalled will be replaced - - Using the most recent patch version will result in a very quick setup since no downloads will be required since a locally installed version Python on the runner will be used + - The only downside to this is that set up will take a little longer since the exact version will have to be downloaded if the exact version is not already installed on the runner due to more recent versions. + - MSI installers are used on Windows for this, so runs will take a little longer to set up vs Mac and Linux. + +You should specify only a major and minor version if you are okay with the most recent patch version being used. + - There will be a single patch version already installed on each runner for every minor version of Python that is supported. + - The patch version that will be preinstalled, will generally be the latest and every time there is a new patch released, the older version that is preinstalled will be replaced. + - Using the most recent patch version will result in a very quick setup since no downloads will be required since a locally installed version Python on the runner will be used. # Using `setup-python` with a self hosted runner