Merge pull request #133 from Zoncovsky/fix/update-link-in-performance-button-slack

Implement performance action URL method in SlackNotificationService

Author: alexshapalov

app/controllers/errors_controller.rb

@@ -68,11 +68,11 @@ def index
                       @q.result.includes(:project).except(:order)
                         .joins("LEFT JOIN (#{subquery_sql}) AS impact_counts ON impact_counts.issue_id = issues.id")
                         .order(Arel.sql("impact_counts.cnt #{dir} NULLS LAST"))
-                    elsif sort_param.present?
+    elsif sort_param.present?
                       @q.result.includes(:project)
-                    else
+    else
                       @q.result.includes(:project).severity_ordered
-                    end
+    end
 
     # Use pagy_countless to skip the expensive SELECT COUNT(*) on millions of rows.
     # Trade-off: we don't show "Page X of Y" or total count in pagination.

app/services/slack_notification_service.rb

@@ -74,6 +74,11 @@ def project_url
     "#{host}/#{@project.slug}"
   end
 
+  def performance_action_url(target)
+    return "#{project_url}/performance" if target.blank? || target == "Unknown"
+    "#{project_url}/performance/actions/#{URI.encode_www_form_component(target)}"
+  end
+
   def error_url(issue, tab: nil, event_id: nil)
     q = []
     q << "tab=#{tab}" if tab
@@ -145,7 +150,7 @@ def build_performance_blocks(event, payload)
       {
         type: "actions",
         elements: [
-          { type: "button", text: { type: "plain_text", text: "View Performance", emoji: true }, url: "#{project_url}/performance", style: "primary" }
+          { type: "button", text: { type: "plain_text", text: "View Performance", emoji: true }, url: performance_action_url(endpoint), style: "primary" }
         ]
       }
     ]
@@ -172,7 +177,7 @@ def build_n_plus_one_blocks(payload)
       {
         type: "actions",
         elements: [
-          { type: "button", text: { type: "plain_text", text: "View Queries", emoji: true }, url: "#{project_url}/performance", style: "primary" }
+          { type: "button", text: { type: "plain_text", text: "View Queries", emoji: true }, url: performance_action_url(controller_action), style: "primary" }
         ]
       }
     ]
@@ -373,7 +378,7 @@ def build_performance_message(event, payload)
             {
               type: "button",
               text: "View Performance",
-              url: "#{project_url}/performance",
+              url: performance_action_url(event.target.presence || payload["target"] || payload["controller_action"] || event.request_path),
               style: "primary"
             }
           ],
@@ -435,7 +440,7 @@ def build_n_plus_one_message(payload)
             {
               type: "button",
               text: "View Queries",
-              url: "#{project_url}/performance",
+              url: performance_action_url(controller_action),
               style: "primary"
             }
           ],