GBTS in throughput examples (#1194)

* Add GBTS options for mt runner

* setting up gbts algs in full_chain cpu/cuda compilation

* GBTS working in the mt

* adding placeholders for backends without GBTS impl

* formatting and placeholders for sycl alpaka

* testing with extra compiler flags

* formatting

* reverting extra compilation flags

* removing submodule

* more itk_throughput tyding

* sign conversion and array type fixes

* rebase fixes

* reabse fixes and adding GBTS to full_chain seeding

* formatting

* reorder arguments

* fixes and adding asserts to alpaka and sycl

* changing asserts to print statments

* add unused to gbts config

* update GBTS not implemented logging

* fix logger

* formatting

* fixed: forgotten rebase conflict

* revert to triplet_seeding_alg output type for the common seed type

* changing "not impl" prints

* char conversion fix

* formating

* fix type name for sycl

* adding gbts_config to full_chain sycl header

* extra configs

* finishing options print out

* ruff formatting

---------

Co-authored-by: Mark Brettell <mbrettel@lxplus902.cern.ch>
Co-authored-by: Mark <markbrettel@cern.ch>
Co-authored-by: Mark Brettell <egi71871@hepacc09.pp.rl.ac.uk>
Co-authored-by: Fabrice Le Goff <fabrice.le.goff@cern.ch>

Author: 5 people

core/include/traccc/gbts_seeding/gbts_seeding_config.hpp

@@ -149,7 +149,7 @@ struct gbts_seedfinder_config {
     unsigned int n_eta_bins = 0;  // calculated from input layerInfo
     unsigned int n_phi_bins = 128;
     // graph making maxiums
-    unsigned char max_num_neighbours = 10;
+    unsigned int max_num_neighbours = 10;
     // graph extraction cuts
     int minLevel = 3;  // equivlent to a cut of #seed edges or #spacepoints-1
 

device/cuda/include/traccc/cuda/gbts_seeding/gbts_seeding_algorithm.hpp

@@ -46,7 +46,7 @@ class gbts_seeding_algorithm
     /// @param str The CUDA stream to perform the operations in
     ///
     gbts_seeding_algorithm(
-        const gbts_seedfinder_config& cfg, traccc::memory_resource& mr,
+        const gbts_seedfinder_config& cfg, const traccc::memory_resource& mr,
         vecmem::copy& copy, stream& str,
         std::unique_ptr<const Logger> logger = getDummyLogger().clone());
 

device/cuda/src/gbts_seeding/gbts_seeding_algorithm.cu

@@ -111,7 +111,7 @@ struct gbts_ctx {
 };
 
 gbts_seeding_algorithm::gbts_seeding_algorithm(
-    const gbts_seedfinder_config& cfg, traccc::memory_resource& mr,
+    const gbts_seedfinder_config& cfg, const traccc::memory_resource& mr,
     vecmem::copy& copy, stream& str, std::unique_ptr<const Logger> logger)
     : messaging(logger->clone()),
       m_config(cfg),
@@ -280,7 +280,6 @@ gbts_seeding_algorithm::output_type gbts_seeding_algorithm::operator()(
         nNodesPerBlock, ctx.nNodes, m_config.n_phi_bins);
 
     cudaStreamSynchronize(stream);
-
     error = cudaGetLastError();
 
     if (error != cudaSuccess) {
@@ -716,8 +715,6 @@ gbts_seeding_algorithm::output_type gbts_seeding_algorithm::operator()(
     data_size = ctx.nConnectedEdges * sizeof(int);
 
     cudaMalloc(&ctx.d_active_edges, data_size);
-    cudaMemsetAsync(ctx.d_active_edges, 0xFF, data_size,
-                    stream);  // initialize to -1
 
     data_size = 2 * ctx.nConnectedEdges * sizeof(unsigned char);
 

examples/options/CMakeLists.txt

@@ -27,6 +27,7 @@ traccc_add_library( traccc_options options TYPE SHARED
   "include/traccc/options/track_propagation.hpp"
   "include/traccc/options/track_resolution.hpp"
   "include/traccc/options/track_seeding.hpp"
+  "include/traccc/options/track_gbts_seeding.hpp"
   # source files
   "src/details/interface.cpp"
   "src/accelerator.cpp"
@@ -49,6 +50,7 @@ traccc_add_library( traccc_options options TYPE SHARED
   "src/track_propagation.cpp"
   "src/track_resolution.cpp"
   "src/track_seeding.cpp"
+  "src/track_gbts_seeding.cpp"
   "src/truth_finding.cpp"
   )
 target_link_libraries( traccc_options

examples/options/include/traccc/options/track_gbts_seeding.hpp

@@ -0,0 +1,48 @@
+/** TRACCC library, part of the ACTS project (R&D line)
+ *
+ * (c) 2022-2024 CERN for the benefit of the ACTS project
+ *
+ * Mozilla Public License Version 2.0
+ */
+
+#pragma once
+
+// Project include(s).
+#include "traccc/gbts_seeding/gbts_seeding_config.hpp"
+#include "traccc/options/details/config_provider.hpp"
+#include "traccc/options/details/interface.hpp"
+
+// System include(s).
+#include <cstddef>
+
+namespace traccc::opts {
+
+/// Option(s) for multi-threaded code execution
+class track_gbts_seeding : public interface,
+                           public config_provider<gbts_seedfinder_config> {
+
+    public:
+    /// @name Options
+    /// @{
+    bool useGBTS = false;
+    std::string config_dir = "DEFAULT";
+
+    /// @}
+    // algorithm config
+    float min_pt = 900;
+    gbts_seedfinder_config gbts_config;
+    explicit operator gbts_seedfinder_config() const override;
+
+    /// Constructor
+    track_gbts_seeding();
+
+    /// Read/process the command line options
+    ///
+    /// @param vm The command line options to interpret/read
+    ///
+    void read(const boost::program_options::variables_map& vm) override;
+
+    std::unique_ptr<configuration_printable> as_printable() const override;
+};
+
+}  // namespace traccc::opts