chore: update compiler target to es2022 (#811)

rofe · web-flow · commit b0ddcda70c3b · 2026-03-03T15:22:25.000+01:00
diff --git a/jsconfig.json b/jsconfig.json
@@ -1,7 +1,7 @@
 {
   "compilerOptions": {
     "checkJs": true,
-    "target": "es2017",
+    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext",
     "resolveJsonModule": true,
diff --git a/src/extension/app/store/app.js b/src/extension/app/store/app.js
@@ -1173,7 +1173,6 @@ export class AppStore {
 
   /**
    * Shows the view.
-   * @private
    */
   async showView() {
     if (!this.isProject()) {
diff --git a/src/extension/ui.js b/src/extension/ui.js
@@ -53,11 +53,11 @@ let updateInProgress = false;
  * @returns {Object<number, string>} The icon paths
  */
 function getPaths(type) {
+  /** @type {Object<number, string>} */
   const paths = {};
   for (const size of ICON_SIZES) {
     paths[size] = `icons/${type}/icon-${size}x${size}.png`;
   }
-  // @ts-ignore
   return paths;
 }
 
@@ -223,7 +223,6 @@ if (chrome.contextMenus) {
           window.hlx = window.hlx || {};
           window.hlx.sidekick = window.hlx.sidekick || { location: window.location };
 
-          // @ts-ignore
           const action = `${menuItemIdVal}`.replaceAll(/([A-Z])/g, `-${'$1'}`).toLowerCase();
           sampleRUM('click', {
             source: 'sidekick',
diff --git a/test/app/components/action-bar/activity-action.test.js b/test/app/components/action-bar/activity-action.test.js
@@ -12,7 +12,6 @@
 
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies, max-len */
 
-// @ts-ignore
 import {
   expect,
   waitUntil,
diff --git a/test/app/components/bulk/bulk-info.test.js b/test/app/components/bulk/bulk-info.test.js
@@ -12,7 +12,6 @@
 
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies, max-len */
 
-// @ts-ignore
 import { expect, waitUntil } from '@open-wc/testing';
 import { AppStore } from '../../../../src/extension/app/store/app.js';
 import { SidekickTest } from '../../../sidekick-test.js';
diff --git a/test/app/components/bulk/bulk-modal.test.js b/test/app/components/bulk/bulk-modal.test.js
@@ -12,7 +12,6 @@
 
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies, max-len */
 
-// @ts-ignore
 import {
   expect, waitUntil, aTimeout,
 } from '@open-wc/testing';
diff --git a/test/app/components/bulk/bulk-result.test.js b/test/app/components/bulk/bulk-result.test.js
@@ -12,7 +12,6 @@
 
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies, max-len */
 
-// @ts-ignore
 import { expect, waitUntil } from '@open-wc/testing';
 import { AppStore } from '../../../../src/extension/app/store/app.js';
 import { SidekickTest } from '../../../sidekick-test.js';
diff --git a/test/app/components/modal/modal.test.js b/test/app/components/modal/modal.test.js
@@ -12,7 +12,6 @@
 
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies, max-len */
 
-// @ts-ignore
 import {
   expect, waitUntil, aTimeout,
 } from '@open-wc/testing';
diff --git a/test/app/components/onboarding/onboarding-modal.test.js b/test/app/components/onboarding/onboarding-modal.test.js
@@ -11,7 +11,6 @@
  */
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies */
 
-// @ts-ignore
 import { expect, waitUntil } from '@open-wc/testing';
 import { recursiveQuery, recursiveQueryAll } from '../../../test-utils.js';
 import chromeMock from '../../../mocks/chrome.js';
diff --git a/test/app/components/plugin/palette-container.test.js b/test/app/components/plugin/palette-container.test.js
@@ -11,7 +11,6 @@
  */
 /* eslint-disable no-unused-expressions, import/no-extraneous-dependencies */
 
-// @ts-ignore
 import { expect, waitUntil } from '@open-wc/testing';
 import { recursiveQuery, recursiveQueryAll } from '../../../test-utils.js';
 import chromeMock from '../../../mocks/chrome.js';
diff --git a/test/app/components/plugin/plugin.test.js b/test/app/components/plugin/plugin.test.js
@@ -354,7 +354,6 @@ describe('Plugin', () => {
       pinned: false,
     }, appStore);
     const renderedPlugin = plugin.render();
-    // @ts-ignore
     expect(renderedPlugin).to.equal('');
   });
 
@@ -367,7 +366,6 @@ describe('Plugin', () => {
     parent.append(child);
 
     const renderedPlugin = parent.render();
-    // @ts-ignore
     expect(renderedPlugin).to.equal('');
   });
 
diff --git a/test/app/store/site.test.js b/test/app/store/site.test.js
@@ -130,9 +130,6 @@ describe('Test Site Store', () => {
     });
 
     it('special views ', async () => {
-      /**
-       * @type {SidekickOptionsConfig | ClientConfig}
-       */
       const config = {
         ...defaultConfig,
         specialViews: [
diff --git a/test/mocks/discover.js b/test/mocks/discover.js
@@ -42,7 +42,6 @@ export function mockDiscoveryCall({
     if (failDiscovery) {
       return new Response('', { status: 404 });
     }
-    // @ts-ignore
     const path = new URL(url).pathname;
     if (path.startsWith('/discover')) {
       if (emptyDiscovery) {
@@ -59,7 +58,6 @@ export function mockDiscoveryCall({
     if (failEditInfo) {
       return new Response('', { status: 404 });
     }
-    // @ts-ignore
     const path = new URL(url).pathname;
     if (path.startsWith('/_api/v2.0/shares/')) {
       if (failEditInfo) {
diff --git a/test/project.test.js b/test/project.test.js
@@ -502,7 +502,6 @@ describe('Test project', () => {
       {
         org: 'foo',
         site: 'bar',
-        // @ts-ignore
         originalSite: true,
       },
     ]);
@@ -522,7 +521,6 @@ describe('Test project', () => {
     const shareinvalidgiturl = await getProjectFromUrl(mockTab('https://www.aem.live/tools/sidekick/?giturl=https://www.example.com'));
     expect(shareinvalidgiturl).to.eql({});
 
-    // @ts-ignore
     const none = await getProjectFromUrl();
     expect(none).to.eql({});
   });
diff --git a/test/sharepoint.test.js b/test/sharepoint.test.js
@@ -68,7 +68,6 @@ describe('sharepoint helper', () => {
       action: 'saveDocument',
       url: mockUrl,
     };
-    // @ts-ignore
     await listenerAdded(message, mockSender, sendResponse);
 
     expect(dispatchEventStub.calledWithMatch({ key: 's' })).to.be.true;
@@ -101,7 +100,6 @@ describe('sharepoint helper', () => {
     const message = {
       action: 'somethingElse',
     };
-    // @ts-ignore
     await listenerAdded(message, mockSender, sendResponse);
 
     expect(sendResponse.calledWith(false)).to.be.true;
diff --git a/test/tab.test.js b/test/tab.test.js
@@ -56,7 +56,6 @@ describe('Test check-tab', () => {
   function fakeListenerCallback({ msg, api = chrome.runtime.onMessage, tab = TABS[1] }) {
     const stub = sandbox.stub(api, 'addListener')
       .callsFake((callback) => {
-        // @ts-ignore - Chrome types are not fully accurate
         callback(msg, { tab }, () => {});
         return true;
       });
@@ -250,7 +249,6 @@ describe('Test check-tab', () => {
   });
 
   it('getCurrentTab', async () => {
-    // @ts-ignore
     sandbox.stub(chrome.tabs, 'query').withArgs({ active: true, currentWindow: true }).resolves([TABS[1]]);
     const tab = await getCurrentTab();
     expect(tab).to.equal(TABS[1]);
diff --git a/test/ui.test.js b/test/ui.test.js
@@ -149,7 +149,6 @@ describe('Test UI: updateContextMenu', () => {
   it('updateContextMenu: chrome.contextMenus API missing', async () => {
     const originalContextMenus = chrome.contextMenus;
     delete chrome.contextMenus;
-    // @ts-ignore
     await updateContextMenu({});
     expect(removeAllSpy.callCount).to.equal(0);
     chrome.contextMenus = originalContextMenus;
diff --git a/test/url-cache.test.js b/test/url-cache.test.js
@@ -96,7 +96,6 @@ describe('Test url-cache', () => {
         expect(listener).to.be.a('function');
         onMessageListener = listener;
       });
-      // @ts-ignore
       sendMessage = sandbox.stub(window.chrome.runtime, 'sendMessage').callsFake((message) => {
         expect(onMessageListener).to.be.a('function');
         expect(message).to.be.an('object');
diff --git a/test/utils/admin.test.js b/test/utils/admin.test.js
@@ -23,13 +23,11 @@ describe('helix-admin', () => {
 
   describe('getAdminUrl', () => {
     it('creates a correct URL with all parameters', () => {
-      // @ts-ignore
       const url = createAdminUrl(siteStore, 'preview', '/path/to/resource');
       expect(url.toString()).to.equal('https://admin.hlx.page/preview/adobe/aem-boilerplate/main/path/to/resource');
     });
 
     it('creates a correct URL with default path', () => {
-      // @ts-ignore
       const url = createAdminUrl(siteStore, 'preview', '/path/to/resource');
       expect(url.toString()).to.equal('https://admin.hlx.page/preview/adobe/aem-boilerplate/main/path/to/resource');
     });
@@ -53,14 +51,11 @@ describe('helix-admin', () => {
     });
 
     it('omits adminVersion when not specified', () => {
-      // @ts-ignore
       const url = createAdminUrl(siteStore, 'apiEndpoint', '/path');
-      // @ts-ignore
       expect(url.searchParams.has('hlx-admin-version')).to.equal(false);
     });
 
     it('creates discover URL correctly', () => {
-      // @ts-ignore
       const url = createAdminUrl({}, 'discover', '', new URLSearchParams('url=https://example.com'));
       expect(url.toString()).to.equal('https://admin.hlx.page/discover?url=https%3A%2F%2Fexample.com');
     });
@@ -69,7 +64,6 @@ describe('helix-admin', () => {
       const searchParams = new URLSearchParams();
       searchParams.append('param1', 'value1');
       searchParams.append('param2', 'value2');
-      // @ts-ignore
       const url = createAdminUrl(siteStore, 'preview', '/path', searchParams);
       expect(url.searchParams.get('param1')).to.equal('value1');
       expect(url.searchParams.get('param2')).to.equal('value2');
@@ -78,28 +72,24 @@ describe('helix-admin', () => {
     describe('API v2', () => {
       it('creates correct URL for login endpoint', () => {
         const config = { ...siteStore, apiUpgrade: true };
-        // @ts-ignore
         const url = createAdminUrl(config, 'login');
         expect(url.toString()).to.equal('https://api.aem.live/login?org=adobe&site=aem-boilerplate');
       });
 
       it('creates correct URL for logout endpoint', () => {
         const config = { ...siteStore, apiUpgrade: true };
-        // @ts-ignore
         const url = createAdminUrl(config, 'logout');
         expect(url.toString()).to.equal('https://api.aem.live/logout?org=adobe&site=aem-boilerplate');
       });
 
       it('creates correct URL for profile endpoint', () => {
         const config = { ...siteStore, apiUpgrade: true };
-        // @ts-ignore
         const url = createAdminUrl(config, 'profile');
         expect(url.toString()).to.equal('https://api.aem.live/profile?org=adobe&site=aem-boilerplate');
       });
 
       it('creates correct URL for other endpoints', () => {
         const config = { ...siteStore, apiUpgrade: true };
-        // @ts-ignore
         const url = createAdminUrl(config, 'status', '/path/to/resource');
         expect(url.toString()).to.equal('https://api.aem.live/adobe/sites/aem-boilerplate/status/path/to/resource');
       });
@@ -131,7 +121,6 @@ describe('helix-admin', () => {
     it('calls admin api with search paramater', async () => {
       await callAdmin(siteStore, 'preview', '/path/to/resource', { searchParams: new URLSearchParams('foo=bar') });
       const url = fetchStub.getCall(0).args[0];
-      // @ts-ignore
       expect(url.searchParams.get('foo')).to.equal('bar');
     });
 

Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"compilerOptions": {`
`3`	`3`	`"checkJs": true,`
`4`		`- "target": "es2017",`
	`4`	`+ "target": "es2022",`
`5`	`5`	`"module": "nodenext",`
`6`	`6`	`"moduleResolution": "nodenext",`
`7`	`7`	`"resolveJsonModule": true,`