Skip to content

feat(script): sanitize context before returning it to the pipeline#862

Merged
tripodsan merged 7 commits intomasterfrom
new-pipeline-semantics
May 13, 2019
Merged

feat(script): sanitize context before returning it to the pipeline#862
tripodsan merged 7 commits intomasterfrom
new-pipeline-semantics

Conversation

@tripodsan
Copy link
Contributor

fixes #744
fixes #861

@tripodsan tripodsan requested review from kptdobe and trieloff May 10, 2019 09:27
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #862 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #862   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files          43       43           
  Lines        1778     1778           
=======================================
  Hits         1631     1631           
  Misses        147      147

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4faf4de...4698caf. Read the comment docs.

Copy link
Contributor

@trieloff trieloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unclear what's going on here, especially how the changes affect the two bugs you've mentioned.

@tripodsan tripodsan merged commit 4861ec8 into master May 13, 2019
@tripodsan tripodsan deleted the new-pipeline-semantics branch May 13, 2019 06:44
trieloff pushed a commit that referenced this pull request May 13, 2019
# [2.4.0](v2.3.0...v2.4.0) (2019-05-13)

### Features

* **script:** sanitize context before returning it to the pipeline ([#862](#862)) ([4861ec8](4861ec8)), closes [#744](#744) [#861](#861)
@adobe-bot
Copy link
Collaborator

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust OutputTemplate to cope with new pipeline semantics not possible to set response headers in pre.js

3 participants