Skip to content

Commit ce93dbf

Browse files
authored
[MWPW-186048] Updated LANA logs to use severity levels correctly (#5416)
* updated LANA logs to use the severity parameter * fixed unit tests
1 parent 4ab5a0c commit ce93dbf

File tree

55 files changed

+323
-113
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+323
-113
lines changed

libs/blocks/adobetv/adobetv.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,10 @@ import { createTag, getConfig, getFederatedContentRoot } from '../../utils/utils
33

44
let captionsLangMapPromise = null;
55

6-
const logError = (msg, error) => window.lana.log(`${msg}: ${error}`);
6+
const logError = (msg, error) => window.lana.log(`${msg}: ${error}`, {
7+
tags: 'adobetv',
8+
severity: 'error',
9+
});
710

811
const updateCaptionsLang = (url, geo, captionsLangMap) => {
912
if (geo && captionsLangMap) {

libs/blocks/article-feed/article-helpers.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,10 @@ export async function loadTaxonomy() {
135135
a.href = tax.link;
136136
} else {
137137
// eslint-disable-next-line no-console
138-
window.lana.log(`Trying to get a link for an unknown topic: ${topic} (current page)`, { tags: 'article-feed' });
138+
window.lana.log(
139+
`Trying to get a link for an unknown topic: ${topic} (current page)`,
140+
{ tags: 'article-feed', severity: 'warning' },
141+
);
139142
a.href = '#';
140143
}
141144
delete a.dataset.topicLink;

libs/blocks/article-header/article-header.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ async function validateAuthorUrl(url) {
99
const resp = await fetch(`${url.toLowerCase()}.plain.html`);
1010
if (!resp?.ok) {
1111
/* c8 ignore next 3 */
12-
window.lana?.log(`Could not retrieve metadata for ${url}`, { tags: 'article-header' });
12+
window.lana?.log(`Could not retrieve metadata for ${url}`, { tags: 'article-header', severity: 'critical' });
1313
return null;
1414
}
1515

libs/blocks/caas/utils.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,10 @@ async function getLingoSiteLocale(origin, path, fqdn = 'www.adobe.com') {
678678
});
679679
return lingoSiteMapping;
680680
} catch (e) {
681-
window.lana?.log('Failed to load lingo-site-mapping.json:', e);
681+
window.lana?.log(`Failed to load lingo-site-mapping.json: ${e}`, {
682+
tags: 'caas',
683+
severity: 'error',
684+
});
682685
}
683686
return lingoSiteMapping;
684687
}

libs/blocks/event-rich-results/event-rich-results.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ function logNullValues(obj) {
1616
Object.keys(obj).forEach((key) => {
1717
const value = obj[key];
1818
if (!value || value === '') {
19-
window.lana.log(`Event property ${key} is not defined`, { tags: 'event-rich-results' });
19+
window.lana.log(`Event property ${key} is not defined`, { tags: 'event-rich-results', severity: 'warning' });
2020
}
2121
logNullValues(value);
2222
});

libs/blocks/faas/utils.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,10 @@ const beforeSubmitCallback = () => {
248248
}),
249249
})
250250
.catch((error) => {
251-
window.lana.log(`AA Sandbox Error: ${error.reason || error.error || error.message || error}`, { tags: 'faas', errorType: 'i' });
251+
window.lana.log(
252+
`AA Sandbox Error: ${error.reason || error.error || error.message || error}`,
253+
{ tags: 'faas', errorType: 'i', severity: 'error' },
254+
);
252255
});
253256
}
254257
};

libs/blocks/fragment/fragment.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,10 @@ export default async function init(a) {
127127
}
128128

129129
if (isCircularRef(relHref)) {
130-
window.lana?.log(`ERROR: Fragment Circular Reference loading ${a.href}`);
130+
window.lana?.log(`Fragment Circular Reference loading ${a.href}`, {
131+
tags: 'fragment',
132+
severity: 'error',
133+
});
131134
return;
132135
}
133136

@@ -264,7 +267,10 @@ export default async function init(a) {
264267
return;
265268
}
266269
const message = `Could not get ${shouldFetchMepLingo ? 'mep-lingo ' : ''}fragment: ${resourcePath}.plain.html`;
267-
window.lana?.log(message);
270+
window.lana?.log(message, {
271+
tags: 'fragment',
272+
severity: 'error',
273+
});
268274
return;
269275
}
270276

@@ -275,7 +281,10 @@ export default async function init(a) {
275281

276282
const sections = doc.querySelectorAll('body > div');
277283
if (!sections.length) {
278-
window.lana?.log(`Could not make fragment: ${resourcePath}.plain.html`);
284+
window.lana?.log(`Could not make fragment: ${resourcePath}.plain.html`, {
285+
tags: 'fragment',
286+
severity: 'error',
287+
});
279288
return;
280289
}
281290

libs/blocks/global-footer/global-footer.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ class Footer {
174174
error.tags = 'global-footer';
175175
error.url = url;
176176
error.errorType = 'e';
177+
error.severity = 'error';
177178
lanaLog({ message: error.message, ...error });
178179
const { onFooterError } = getConfig();
179180
onFooterError?.(error);
@@ -272,6 +273,7 @@ class Footer {
272273
e: `${file.statusText} url: ${file.url}`,
273274
tags: 'global-footer',
274275
errorType: 'i',
276+
severity: 'error',
275277
});
276278
}
277279
const content = await file.text();
@@ -320,7 +322,11 @@ class Footer {
320322
try {
321323
url = new URL(regionSelector.href);
322324
} catch (e) {
323-
lanaLog({ message: `Could not create URL for region picker; href: ${regionSelector.href}`, tags: 'global-footer', errorType: 'e' });
325+
lanaLog({
326+
message: `Could not create URL for region picker; href: ${regionSelector.href}`,
327+
tags: 'global-footer',
328+
severity: 'critical',
329+
});
324330
return this.elements.regionPicker;
325331
}
326332

@@ -565,7 +571,12 @@ export default function init(block) {
565571
if (isDarkMode()) block.classList.add('feds--dark');
566572
return footer;
567573
} catch (e) {
568-
lanaLog({ message: 'Could not create footer', e });
574+
lanaLog({
575+
message: 'Could not create footer',
576+
e,
577+
tags: 'global-footer',
578+
severity: 'critical',
579+
});
569580
return null;
570581
}
571582
}

libs/blocks/global-navigation/features/aside/aside.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,11 @@ export default async function decorateAside({ headerElem, fedsPromoWrapper, prom
66
const onError = () => {
77
fedsPromoWrapper?.remove();
88
headerElem?.classList.remove('has-promo');
9-
lanaLog({ message: 'Gnav Promo fragment not replaced, potential CLS' });
9+
lanaLog({
10+
message: 'Gnav Promo fragment not replaced, potential CLS',
11+
tags: 'aside',
12+
severity: 'warning',
13+
});
1014
return '';
1115
};
1216

libs/blocks/global-navigation/features/breadcrumbs/breadcrumbs.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,13 @@ const createWithBase = async (el) => {
8686
element.querySelector('ul')?.prepend(...base.querySelectorAll('li'));
8787
return createBreadcrumbs(element);
8888
} catch (e) {
89-
lanaLog({ e, message: 'Breadcrumbs failed fetching base', tags: 'gnav-breadcrumbs', errorType: 'i' });
89+
lanaLog({
90+
e,
91+
message: 'Breadcrumbs failed fetching base',
92+
tags: 'gnav-breadcrumbs',
93+
errorType: 'i',
94+
severity: 'error',
95+
});
9096
return null;
9197
}
9298
};
@@ -115,7 +121,12 @@ export default async function init(el) {
115121
setBreadcrumbSEO(breadcrumbsEl);
116122
return breadcrumbsEl;
117123
} catch (e) {
118-
lanaLog({ e, message: 'Breadcrumbs failed rendering', tags: 'gnav-breadcrumbs', errorType: 'e' });
124+
lanaLog({
125+
e,
126+
message: 'Breadcrumbs failed rendering',
127+
tags: 'gnav-breadcrumbs',
128+
severity: 'error',
129+
});
119130
return null;
120131
}
121132
}

0 commit comments

Comments
 (0)