Latest version pulls in server dependencies in client modules

[JanStevens]

Package version

8.1.0

Describe the bug

Hi,

After upgrading to latest version I noticed that I ended up with a blank page cause by the frontend error. Using inertia and tuyau.

TypeError: (0 , import_node_module.createRequire) is not a function
    at chunk-B2GA45YG.js:33:33

Tracing it back it seems that the build artifacts pull in the server chunk causing the issues (see https://www.npmjs.com/package/@adonisjs/http-server?activeTab=code and navigate to build/src/client/url_builder.js).

When patching the dependency to remove the line everything works again

diff --git a/node_modules/@adonisjs/http-server/build/src/client/url_builder.js b/node_modules/@adonisjs/http-server/build/src/client/url_builder.js
index 38d91e0..37da766 100644
--- a/node_modules/@adonisjs/http-server/build/src/client/url_builder.js
+++ b/node_modules/@adonisjs/http-server/build/src/client/url_builder.js
@@ -1,4 +1,3 @@
-import "../../chunk-B2GA45YG.js";
 import { n as findRoute, t as createURL } from "../../helpers-XD4_pfkD.js";
 //#region src/client/url_builder.ts
 /**

Reproduction repo

No response

[thetutlage]

Thanks for reporting. It seems the issue happened in this commit as we upgraded tsdown. 725b238

Can you please create a PR that downgrades the tsdown version to its previous version?

I am not in front of computer, but can do a release if you can fix it

[JanStevens]

Thanks for reporting. It seems the issue happened in this commit as we upgraded tsdown. 725b238

Can you please create a PR that downgrades the tsdown version to its previous version?

I am not in front of computer, but can do a release if you can fix it

Allright, tested it locally and that indeed seem to fix it

[Julien-R44]

Ooops sorry missed your pull request man @JanStevens. I was investigating on it

So for now, i just reverted tsdown to 0.20.3 where it works fine and created a new release https://github.com/adonisjs/http-server/releases/tag/v8.1.1

After quick investigations, found that we have multiple more future proof solutions:

• treeshake: true: for some reasons this fixes it, rolldown correctly shakes out the unused CJS chunk from the client entry. Diffed the output and zero functional code gets removed, only the dead shim. But not 100% sure treeshake wont bite us elsewhere so need more testing
• Split build config: two separate build passes in tsdown.config.ts, one for server entries (with CJS deps), one for the client entry (standalone). Works perfectly but adds config complexity. probably our best option. also need more testing
• platform: 'neutral': also prevents the CJS shim generation but might have some weird side effects...
• Might also report upstream to rolldown since that chunk really shouldn't leak into entries that don't need it. I am not 100% sure this behavior is expected to be honest.

Didnt had a lot of time right now, so will follow up with a proper fix once we figure out the cleanest approach