imp(keyring): improve UX for keyring.List (cosmos#13369)

* imp(keyring): improve UX for keyring.List

* use offline info in case of error

* Delete .dccache

* c++

* conflicts

Author: fedekunze

.gitignore

@@ -6,6 +6,7 @@
 *.swm
 *.swn
 *.pyc
+.dccache
 
 # private files
 private[.-]*

CHANGELOG.md

@@ -40,8 +40,9 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Improvements
 
+* [#13369](https://github.com/cosmos/cosmos-sdk/pull/13369) Improve UX for `keyring.List` by returning all retrieved keys.
 * [#13323](https://github.com/cosmos/cosmos-sdk/pull/13323) Ensure `withdraw_rewards` rewards are emitted from all actions that result in rewards being withdrawn.
-* [#13321](https://github.com/cosmos/cosmos-sdk/pull/13321) Add flag to disable fast node migration and usage. 
+* [#13321](https://github.com/cosmos/cosmos-sdk/pull/13321) Add flag to disable fast node migration and usage.
 
 ### API Breaking Changes
 

crypto/keyring/keyring.go

@@ -535,8 +535,56 @@ func wrapKeyNotFound(err error, msg string) error {
 	return err
 }
 
-func (ks keystore) List() ([]*Record, error) {
-	return ks.MigrateAll()
+func (ks keystore) List() ([]Info, error) {
+	res := []Info{}
+
+	keys, err := ks.db.Keys()
+	if err != nil {
+		return nil, err
+	}
+
+	if len(keys) == 0 {
+		return res, nil
+	}
+
+	sort.Strings(keys)
+	for _, key := range keys {
+		if strings.HasSuffix(key, infoSuffix) {
+			rawInfo, err := ks.db.Get(key)
+			if err != nil {
+				fmt.Printf("err for key %s: %q\n", key, err)
+
+				// add the name of the key in case the user wants to retrieve it
+				// afterwards
+				info := newOfflineInfo(key, nil, hd.PubKeyType(""))
+				res = append(res, info)
+				continue
+			}
+
+			if len(rawInfo.Data) == 0 {
+				fmt.Println(sdkerrors.Wrap(sdkerrors.ErrKeyNotFound, key))
+
+				// add the name of the key in case the user wants to retrieve it
+				// afterwards
+				info := newOfflineInfo(key, nil, hd.PubKeyType(""))
+				res = append(res, info)
+				continue
+			}
+
+			info, err := unmarshalInfo(rawInfo.Data)
+			if err != nil {
+				fmt.Printf("err for key %s: %q\n", key, err)
+
+				// add the name of the key in case the user wants to retrieve it
+				// afterwards
+				info = newOfflineInfo(key, nil, hd.PubKeyType(""))
+			}
+
+			res = append(res, info)
+		}
+	}
+
+	return res, nil
 }
 
 func (ks keystore) NewMnemonic(uid string, language Language, hdPath, bip39Passphrase string, algo SignatureAlgo) (*Record, string, error) {