Merge pull request #162 from ainblockchain/develop

Release v0.5.0

Author: minsulee2

.github/ISSUE_TEMPLATE/ask-a-question.md

@@ -0,0 +1,24 @@
+---
+name: "\U0001F914 Ask a question"
+about: Ask about this project
+title: ''
+labels: question
+assignees: ''
+
+---
+
+## For general questions please join [AINetwork Slack](https://join.slack.com/t/cloud-native/shared_invite/zt-fyy3b8up-qHeDNVqbz1j8HDY6g1cY4w) and ask at [#help_en](https://ainetwork-dev.slack.com/archives/C016JB5VADV) channel.
+
+
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

.github/ISSUE_TEMPLATE/bug-report.md

@@ -0,0 +1,32 @@
+---
+name: "\U0001F41B Bug report"
+about: Create a report to help us improve
+title: "[BUG] "
+labels: bug
+assignees: ''
+
+---
+
+**Describe the bug**
+A clear and concise description of what the bug is.
+
+**To Reproduce**
+Steps to reproduce the behavior:
+1. Go to '...'
+2. Install and import ain-util '....'
+3. call function abc() '....'
+4. See error
+
+**Expected behavior**
+A clear and concise description of what you expected to happen.
+
+**System information:**
+ - OS & version: [e.g. Windows/Linux/OSX]
+ - ain-util version: [e.g. 1.1.6]
+ - Commit hash: [e.g. 8cf3db6]
+
+**Screenshots**
+If applicable, add screenshots to help explain your problem.
+
+**Additional context**
+Add any other context about the problem here.

.github/ISSUE_TEMPLATE/feature-request.md

@@ -0,0 +1,20 @@
+---
+name: "\U0001F4A1 Feature request"
+about: Suggest an idea for this project
+title: ''
+labels: new feature
+assignees: ''
+
+---
+
+**Is your feature request related to a problem? Please describe.**
+A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
+
+**Describe the solution you'd like**
+A clear and concise description of what you want to happen.
+
+**Describe alternatives you've considered**
+A clear and concise description of any alternative solutions or features you've considered.
+
+**Additional context**
+Add any other context or screenshots about the feature request here.

blockchain/block.js

@@ -81,7 +81,7 @@ class Block {
     return ChainUtil.hashString(stringify(block.header));
   }
 
-  static createBlock(lastHash, lastVotes, transactions, number, epoch,
+  static create(lastHash, lastVotes, transactions, number, epoch,
       stateProofHash, proposer, validators) {
     return new Block(lastHash, lastVotes, transactions, number, epoch, Date.now(),
         stateProofHash, proposer, validators);
@@ -133,30 +133,30 @@ class Block {
   static validateProposedBlock(block) {
     if (!Block.validateHashes(block)) return false;
     const nonceTracker = {};
-    let transaction;
+    let tx;
     for (let i = 0; i < block.transactions.length; i++) {
-      transaction = block.transactions[i];
-      if (transaction.nonce < 0) {
+      tx = block.transactions[i];
+      if (tx.tx_body.nonce < 0) {
         continue;
       }
-      if (!(transaction.address in nonceTracker)) {
-        nonceTracker[transaction.address] = transaction.nonce;
+      if (!(tx.address in nonceTracker)) {
+        nonceTracker[tx.address] = tx.tx_body.nonce;
         continue;
       }
-      if (transaction.nonce != nonceTracker[transaction.address] + 1) {
-        logger.error(`Invalid noncing for ${transaction.address} ` +
-            `Expected ${nonceTracker[transaction.address] + 1} ` +
-            `Received ${transaction.nonce}`);
+      if (tx.tx_body.nonce != nonceTracker[tx.address] + 1) {
+        logger.error(`Invalid noncing for ${tx.address} ` +
+            `Expected ${nonceTracker[tx.address] + 1} ` +
+            `Received ${tx.tx_body.nonce}`);
         return false;
       }
-      nonceTracker[transaction.address] = transaction.nonce;
+      nonceTracker[tx.address] = tx.tx_body.nonce;
     }
 
     logger.info(`Valid block of number ${block.number}`);
     return true;
   }
 
-  static getDbSetupTransaction(timestamp, keyBuffer) {
+  static buildDbSetupTx(timestamp, privateKey) {
     const opList = [];
 
     // Values operation
@@ -188,19 +188,18 @@ class Block {
     });
 
     // Transaction
-    const firstTxData = {
+    const firstTxBody = {
       nonce: -1,
       timestamp,
       operation: {
         type: 'SET',
         op_list: opList,
       }
     };
-    const firstSig = ainUtil.ecSignTransaction(firstTxData, keyBuffer);
-    return (new Transaction({signature: firstSig, transaction: firstTxData}));
+    return Transaction.signTxBody(firstTxBody, privateKey);
   }
 
-  static getAccountsSetupTransaction(ownerAddress, timestamp, keyBuffer) {
+  static buildAccountsSetupTx(ownerAddress, timestamp, privateKey) {
     const transferOps = [];
     const otherAccounts = GenesisAccounts[AccountProperties.OTHERS];
     if (otherAccounts && Array.isArray(otherAccounts) && otherAccounts.length > 0 &&
@@ -219,27 +218,25 @@ class Block {
     }
 
     // Transaction
-    const secondTxData = {
+    const secondTxBody = {
       nonce: -1,
       timestamp,
       operation: {
         type: 'SET',
         op_list: transferOps
       }
     };
-    const secondSig = ainUtil.ecSignTransaction(secondTxData, keyBuffer);
-    return (new Transaction({signature: secondSig, transaction: secondTxData}));
+    return Transaction.signTxBody(secondTxBody, privateKey);
   }
 
   static getGenesisBlockData(genesisTime) {
     const ownerAddress = ChainUtil.getJsObject(
         GenesisAccounts, [AccountProperties.OWNER, AccountProperties.ADDRESS]);
     const ownerPrivateKey = ChainUtil.getJsObject(
         GenesisAccounts, [AccountProperties.OWNER, AccountProperties.PRIVATE_KEY]);
-    const keyBuffer = Buffer.from(ownerPrivateKey, 'hex');
 
-    const firstTx = this.getDbSetupTransaction(genesisTime, keyBuffer);
-    const secondTx = this.getAccountsSetupTransaction(ownerAddress, genesisTime, keyBuffer);
+    const firstTx = this.buildDbSetupTx(genesisTime, ownerPrivateKey);
+    const secondTx = this.buildAccountsSetupTx(ownerAddress, genesisTime, ownerPrivateKey);
 
     return [firstTx, secondTx];
   }