fix onSelected event for markers with custom view#1079
Merged
lelandrichardson merged 1 commit intoreact-native-maps:masterfrom Mar 26, 2017
Merged
fix onSelected event for markers with custom view#1079lelandrichardson merged 1 commit intoreact-native-maps:masterfrom
lelandrichardson merged 1 commit intoreact-native-maps:masterfrom
Conversation
yonahforst
changed the title
yonahforst
changed the title
Collaborator
|
Thank you! |
|
this creates an issue when you have multiple markers close together, the callout box jumps between the different markers |
This was referenced Sep 9, 2019
|
Can this be hidden behind a flag? I believe it's causing multiple callouts to open on iOS when they're nearby. |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
fix onSelected event for markers with custom view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addresses #436, parts of #553
Problem: when using markers with a custom subview,
didSelectAnnotationdoes not get triggered on tap events, unless you press on the outside edge of the marker (outside the subview but inside the marker)Solution: 'marker-press' events manually call
selectAnnotationon the marker's mapview