Skip to content

Issue1176 improve ios marker performance by X100#1187

Merged
christopherdro merged 6 commits intoreact-native-maps:masterfrom
ericapply:issue1176-ios-marker-performance
Aug 15, 2017
Merged

Issue1176 improve ios marker performance by X100#1187
christopherdro merged 6 commits intoreact-native-maps:masterfrom
ericapply:issue1176-ios-marker-performance

Conversation

@ericapply
Copy link
Copy Markdown
Contributor

@ericapply ericapply commented Apr 5, 2017 •
edited
Loading

Fix problem #1176

When image props is provided, it will re-use UIImage if the image is same.

This will increase the performance by more than X100

@ericapply ericapply mentioned this pull request Apr 5, 2017
Closed
@ericapply ericapply changed the title Issue1176 ios marker performance Issue1176 improve ios marker performance by X100 Apr 5, 2017
@christopherdro
Copy link
Copy Markdown
Collaborator

christopherdro commented May 11, 2017

Looks great.
Can we get the merge conflicts resolved so we can give this a proper review?

@ericapply
Copy link
Copy Markdown
Contributor Author

ericapply commented May 12, 2017

Really busy today, I will try to resolve merge conflicts asap

@ryancoughlin
Copy link
Copy Markdown

ryancoughlin commented May 17, 2017

Thanks @ericapply, been using a forked version of this to get past this. Huge improvement.

@bosung90
Copy link
Copy Markdown

bosung90 commented May 19, 2017 •
edited
Loading

Please merge!🎉 @christopherdro

@grundmanise
Copy link
Copy Markdown

grundmanise commented May 19, 2017

@christopherdro please merge this PR

christopherdro
christopherdro reviewed May 19, 2017
View reviewed changes
lib/ios/AirGoogleMaps/GlobalVars.h Outdated
@@ -0,0 +1,23 @@
//
// GlobalVars.h
// EvoApp
Copy link
Copy Markdown
Collaborator

@christopherdro christopherdro May 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove reference to EvoApp

@christopherdro
Copy link
Copy Markdown
Collaborator

christopherdro commented May 19, 2017

@spikebrehm @lelandrichardson Any chance you can take a look?

This PR still needs to be tested and reviewed. There is no sense is rushing to merge this.
@bosung90 @grundmanise You can do what @ryancoughlin does for the time being if you really need this feature.

@christopherdro christopherdro merged commit b908c08 into react-native-maps:master Aug 15, 2017
@ryancoughlin
Copy link
Copy Markdown

ryancoughlin commented Aug 15, 2017

Bless your heart @christopherdro 🙌 🙏

I was getting nervous.

codedre pushed a commit to hzdg/react-native-maps that referenced this pull request Aug 15, 2017
@ericapply @codedre
Issue1176 improve ios marker performance by X100 (react-native-maps#1187
8df4817 
)

* Issue1176 attempt to fix UI lag success by re-using UIImage

* Now use NSMutableDictionary instead of single UIImage

* appearAnimation happen at init rather than setIcon

* Init NSMutableDictionary

* Remove reference to other app
christopherdro added a commit that referenced this pull request Aug 17, 2017
@christopherdro
Revert "Issue1176 improve ios marker performance by X100 (#1187)"
cbdeeaf 
This reverts commit b908c08.
@christopherdro
Copy link
Copy Markdown
Collaborator

christopherdro commented Aug 17, 2017

This has been reverted until we can resolve #1560

codedre pushed a commit to hzdg/react-native-maps that referenced this pull request Aug 17, 2017
@christopherdro @codedre
Revert "Issue1176 improve ios marker performance by X100 (react-nativ…
6952e17 
…e-maps#1187)"

This reverts commit b908c08.
sorodrigo pushed a commit to Vizzuality/react-native-maps that referenced this pull request Aug 21, 2017
Merge branch 'master' of https://github.com/airbnb/react-native-maps
a509377 
* 'master' of https://github.com/airbnb/react-native-maps:
  v0.16.2
  Revert "Issue1176 improve ios marker performance by X100 (react-native-maps#1187)"
  Fix initial region android (react-native-maps#1563)
  v0.16.1
  Enhance Podfile. (react-native-maps#1252)
  Update marker component (react-native-maps#1428)
  Add legalNotice constant (react-native-maps#1458)
  Issue1176 improve ios marker performance by X100 (react-native-maps#1187)
  Fix initial region native prop (react-native-maps#1546)
  fix `Archive` configuration for iOS builds (react-native-maps#1550)
  v0.16.0
  Document MapView min/max zoom properties (react-native-maps#1538)
  Fix timing function used in AnimatedRegion.spring (react-native-maps#1479)
  Fix crashing the application when a user presses on the map and the Google Play Services need to be updated or at the moment of the process of updating (react-native-maps#1469)
  skip region monitoring if map object is null (react-native-maps#1443)
  Zoom level fixes (react-native-maps#1485)
  Attempt to fix crashes. A variant of react-native-maps#1403 but for another lifecycle method, as proposed by @Nelrohd. (react-native-maps#1464)
  Handle Android RN 0.47 breaking change (react-native-maps#1481)
  add MKTileOverlayRenderer (react-native-maps#1357)
  Add onMapReady callback (react-native-maps#1369)
retani added a commit to intergestalt/MareeLettres that referenced this pull request Aug 31, 2017
@retani
update react-native-maps to 0.16.2 for more speed: react-native-maps/…
97b57e5 
…react-native-maps#1187
pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this pull request Sep 27, 2017
@ericapply
Issue1176 improve ios marker performance by X100 (react-native-maps#1187
224c3ae 
)

* Issue1176 attempt to fix UI lag success by re-using UIImage

* Now use NSMutableDictionary instead of single UIImage

* appearAnimation happen at init rather than setIcon

* Init NSMutableDictionary

* Remove reference to other app
pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this pull request Sep 27, 2017
@christopherdro
Revert "Issue1176 improve ios marker performance by X100 (react-nativ…
b6a4cfb 
…e-maps#1187)"

This reverts commit b908c08.
@ngandhy
Copy link
Copy Markdown

ngandhy commented Sep 27, 2017

@ericapply - any luck solving #1560?

Undefined symbols for architecture x86_64:
"OBJC_CLASS$_GlobalVars", referenced from:
objc-class-ref in AIRGoogleMapMarker.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

@grubstarstar
Copy link
Copy Markdown

grubstarstar commented Nov 2, 2021

@ericapply @christopherdro Any luck getting this going? I'm desperately in need of getting this if there's a workaround or a patch or anything? Thanks!

pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
@ericapply @christopherdro
Issue1176 improve ios marker performance by X100 (react-native-maps#1187
48e4afc 
)

* Issue1176 attempt to fix UI lag success by re-using UIImage

* Now use NSMutableDictionary instead of single UIImage

* appearAnimation happen at init rather than setIcon

* Init NSMutableDictionary

* Remove reference to other app
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
@christopherdro
Revert "Issue1176 improve ios marker performance by X100 (react-nativ…
6c58834 
…e-maps#1187)"

This reverts commit b908c08.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christopherdro christopherdro christopherdro left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ericapply @christopherdro @ryancoughlin @bosung90 @grundmanise @ngandhy @grubstarstar