Skip to content

[MapMarker] fix android release crash on custom marker#1643

Merged
christopherdro merged 1 commit intoreact-native-maps:masterfrom
cjcaj:master
Sep 14, 2017
Merged

[MapMarker] fix android release crash on custom marker#1643
christopherdro merged 1 commit intoreact-native-maps:masterfrom
cjcaj:master

Conversation

@cjcaj
Copy link
Copy Markdown
Contributor

@cjcaj cjcaj commented Sep 13, 2017

Fixes an error on Android release mode when the Map.Marker has children.

java.lang.NullPointerException: Attempt to invoke virtual method 'int android.graphics.Bitmap.getWidth()' on a null object reference

From Geor23@a83c04a
Closes #907

@christopherdro christopherdro merged commit 6885fda into react-native-maps:master Sep 14, 2017
@amitpdev
Copy link
Copy Markdown

Thanks for merging this. had to use Geor23's fork till now.

pjaraherrera pushed a commit to pjaraherrera/react-native-maps that referenced this pull request Sep 27, 2017
sorodrigo pushed a commit to Vizzuality/react-native-maps that referenced this pull request Oct 23, 2017
…into upstream-update

* 'master' of https://github.com/airbnb/react-native-maps:
  v0.17.0
  Update index.d.ts
  v0.16.4
  [MapMarker] fix android release crash on custom marker (react-native-maps#1643)
  Add support for animateToViewingAngle and animateToBearing for Android
  Bump 0.16.3
  Revert "[MapView] revert initialRegion change (react-native-maps#1613)"
  [MapView] revert initialRegion change (react-native-maps#1613)
  Added missing satellite option for iOS Google Maps (react-native-maps#1603)
  Remove legalNotice from android AirMapModule As per https://developers.google.com/android/reference/com/google/android/gms/common/GooglePlayServicesUtil this information does not need to be displayed in app.
  Set initial region on view (react-native-maps#1579)
  Added Typescript Definitions
  Updated "showsIndoorLevelPicker" documentation.
  Added [iOS / Google Maps] support for showsIndoorLevelPicker.
  Fall back to View.propTypes if ViewPropTypes is not available (react-native-maps#1473) (react-native-maps#1474)
  fixe mistakes on circle.md (react-native-maps#1584)
  Add support for AirMap (Native IOS Maps) as suggested on the PR comments.
  Adds support to animateToBearing and animateToViewingAngle functions on IOS.
  fix rare android crashes when map size is 0
  Remove caret from "react": "^16.0.0-alpha.12"
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants