Allow fitToCoordinates to be called without options parameter#1817
Merged
christopherdro merged 1 commit intoreact-native-maps:masterfrom Nov 28, 2017
bramus:patch-1
Merged
Allow fitToCoordinates to be called without options parameter#1817christopherdro merged 1 commit intoreact-native-maps:masterfrom bramus:patch-1
christopherdro merged 1 commit intoreact-native-maps:masterfrom
bramus:patch-1
Conversation
Right now it's not possible to call `fitToCoordinates` without an `options` parameter, even though defaults are defined in the function body. This commit set the default value of the `options` parameter of to an empty object, allowing one to call the function without it _(and with respect for the defaults)_.
christopherdro
approved these changes
Nov 28, 2017
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…native-maps#1817) Right now it's not possible to call `fitToCoordinates` without an `options` parameter, even though defaults are defined in the function body. This commit set the default value of the `options` parameter of to an empty object, allowing one to call the function without it _(and with respect for the defaults)_.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now it's not possible to call
fitToCoordinateswithout anoptionsparameter, even though defaults are defined in the function body.This commit set the default value of the
optionsparameter of to an empty object, allowing one to call the function without it (and with respect for the defaults).