Fix shouldUsePinView#344
Merged
lelandrichardson merged 1 commit intoreact-native-maps:masterfrom Jul 9, 2016
Merged
Conversation
Update shouldUsePinView to handle when `subviews` are not yet updated to reflect `reactSubviews`
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
Fix shouldUsePinView
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update shouldUsePinView to handle when
subviewsare not yet updated to reflectreactSubviews.Feel free to abandon this but quick attempt at a fix of an issue where markers were using the default pins instead of the custom react subviews. Stepping through the code it looks like this runs before
UIView.didUpdateReactSubviewswhensubviewsare actually updated.