[CRASH] Added check on marker class in predicate#485
Merged
spikebrehm merged 1 commit intoreact-native-maps:masterfrom Aug 31, 2016
johnryan:fix-fit-to-supplied-markers
Merged
[CRASH] Added check on marker class in predicate#485spikebrehm merged 1 commit intoreact-native-maps:masterfrom johnryan:fix-fit-to-supplied-markers
spikebrehm merged 1 commit intoreact-native-maps:masterfrom
johnryan:fix-fit-to-supplied-markers
Conversation
johnryan
changed the title
|
Thanks! 🍻 |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…plied-markers [CRASH] Added check on marker class in predicate
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation will crash if you call fitToSuppliedMarkers while showsUserLocation is set to true because of an unchecked cast of the MKUserLocation marker.