[Android] Minor code cleanup#564
Merged
spikebrehm merged 1 commit intoreact-native-maps:masterfrom Sep 12, 2016
Merged
Conversation
Contributor
felipecsl
commented
Sep 10, 2016
felipecsl
commented
- Remove unused variables and fields
- Fix compiler warnings (unchecked, deprecation, etc)
* Remove unused variables and fields * Fix compiler warnings (unchecked, deprecation, etc)
Contributor
Author
|
@spikebrehm this should be a simple one I guess? |
| polylineView.addToMap(map); | ||
| features.add(index, polylineView); | ||
| Polyline polyline = (Polyline) polylineView.getFeature(); | ||
| polylineMap.put(polyline, polylineView); |
There was a problem hiding this comment.
These maps aren't used, eh? You've smoke tested the example app?
Contributor
Author
There was a problem hiding this comment.
yeah, these maps are never queried
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
[Android] Minor code cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.