Don't fit to elements if no positions added#567
Merged
spikebrehm merged 1 commit intoreact-native-maps:masterfrom Sep 12, 2016
Merged
Don't fit to elements if no positions added#567spikebrehm merged 1 commit intoreact-native-maps:masterfrom
spikebrehm merged 1 commit intoreact-native-maps:masterfrom
Conversation
|
LGTM, thanks. |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…s-fix Don't fit to elements if no positions added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit prevents the crash mentioned in #180. It is identical to the implementation in
AirMapView#fitToSuppliedMarkers().This doesn't actually fix the issue mentioned in #180 because while the app no longer crashes, the elements aren't zoomed unless you use a setTimeout hack or something similar. @igrayson has written about this there.
It would be great to figure out why that isn't working, however.