Skip to content

fix #453#589

Merged
spikebrehm merged 1 commit intoreact-native-maps:masterfrom
fdnhkj:master
Sep 21, 2016
Merged

fix #453#589
spikebrehm merged 1 commit intoreact-native-maps:masterfrom
fdnhkj:master

Conversation

@fdnhkj
Copy link
Copy Markdown
Contributor

@fdnhkj fdnhkj commented Sep 17, 2016

This commit fixes the issue #453.
Tested with

  "dependencies": {
    "react": "15.3.1",
    "react-native": "^0.32.0",
    "react-native-maps": "^0.8.2",
    "react-native-router-flux": "^3.35.0"
  }

@fdnhkj fdnhkj mentioned this pull request Sep 17, 2016
Closed
@jeveloper
Copy link
Copy Markdown

jeveloper commented Sep 18, 2016

Looks good to me.

@spikebrehm your turn :)

@spikebrehm
Copy link
Copy Markdown

spikebrehm commented Sep 20, 2016

Thanks for the contribution!

This essentially reverts #449.

@felipecsl can you TAL?

@spikebrehm
Copy link
Copy Markdown

spikebrehm commented Sep 21, 2016

There's now a merge conflict. @fdnhkj would you mind rebasing?

@fdnhkj
Copy link
Copy Markdown
Contributor Author

fdnhkj commented Sep 21, 2016

@spikebrehm Done :)

@spikebrehm spikebrehm merged commit f4219a2 into react-native-maps:master Sep 21, 2016
This was referenced Sep 28, 2016
Closed
Closed
@haikyuu haikyuu mentioned this pull request Oct 25, 2016
Closed
@ryankask ryankask mentioned this pull request Mar 24, 2017
Closed
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
Merge pull request react-native-maps#589 from fdnhkj/master
ce4bb3c 
fix react-native-maps#453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@felipecsl felipecsl felipecsl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fdnhkj @jeveloper @spikebrehm @felipecsl