Added support for drawing polylines on snapshots on iOS#615
Merged
spikebrehm merged 1 commit intoreact-native-maps:masterfrom Sep 27, 2016
Merged
Conversation
|
Nice, thanks! |
Contributor
Author
|
Awesome, thanks for pulling! FYI, I'm working on the Android implementation of taking snapshots. I'll hopefully push that soon. |
|
Thanks @IjzerenHein ! Any chance you can provide an example? thanks |
Contributor
Author
|
@jeveloper Serge, no you have to add cheers |
|
thanks for sharing that info :) |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
…pshot-polyline Added support for drawing polylines on snapshots on iOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue that polylines are not drawn on snapshots on iOS.
Specifically, it adds infrastructure (the AIRMapSnapshot protocol) to which overlays can conform. The AIRMapSnapshot protocol has one method called
drawToSnapshotwhich can optionally be implemented by overlays.Additionally, this pull request adds the
drawToSnapshotimplementation for the AIRMapPolyline class, causing it to be rendered to snapshots. It should be fairly easy to extends other overlays to support snapshot drawing as well.The example below shows the image that was generated using the
takeSnapshotfunction, including the polyline overlay: