Skip to content

[zIndex] Add support for setting zIndex on markers#675

Merged
spikebrehm merged 5 commits intoreact-native-maps:masterfrom
opendoor-labs:zindex_pr
Oct 13, 2016
Merged

[zIndex] Add support for setting zIndex on markers#675
spikebrehm merged 5 commits intoreact-native-maps:masterfrom
opendoor-labs:zindex_pr

Conversation

@mlanter
Copy link
Copy Markdown
Contributor

@mlanter mlanter commented Oct 11, 2016

Add support for setting the z-index on markers via the style.

Example usage:

<MapView.Marker
  style={styles.importantMarker}
  ... 
/>
const styles = StyleSheet.create({
  importantMarker: {
    zIndex: 1,
  },
});

Test plan:

  • Verify on both iOS and Android that with this fix any markers with a zIndex > 0 show up above any other markers.
  • Verify without the change sometimes markers appear below others.

@spikebrehm
Copy link
Copy Markdown

Awesome, thanks! Can you please add an example to the example app demonstrating this feature? We basically use the example app as manual integration tests.

@carleryd
Copy link
Copy Markdown

Great job, just tested it and it works great! I have been wanting this feature for a long time, looking forward to seeing it in the next release!

@mlanter
Copy link
Copy Markdown
Contributor Author

mlanter commented Oct 12, 2016

Here's an example-

screenshot-2016-10-12_13 17 34 140

@spikebrehm
Copy link
Copy Markdown

@mlanter
Copy link
Copy Markdown
Contributor Author

mlanter commented Oct 13, 2016

Yep! Here's iOS screenshots for Apple and Google Maps-

simulator screen shot oct 13 2016 1 35 19 am
simulator screen shot oct 13 2016 1 35 26 am

Copy link
Copy Markdown

@spikebrehm spikebrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you so much! 🍻

loadingIndicatorColor={"#666666"}
loadingBackgroundColor={"#eeeeee"}
loadingIndicatorColor="#666666"
loadingBackgroundColor="#eeeeee"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spikebrehm spikebrehm merged commit f45e755 into react-native-maps:master Oct 13, 2016
@mlanter mlanter deleted the zindex_pr branch October 13, 2016 18:42
pinpong pushed a commit to pinpong/react-native-maps that referenced this pull request Feb 28, 2025
[zIndex]  Add support for setting zIndex on markers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants