included MapUrlTile usage in README.md#687
Merged
spikebrehm merged 5 commits intoreact-native-maps:masterfrom Oct 13, 2016
ochanje210:master
Merged
included MapUrlTile usage in README.md#687spikebrehm merged 5 commits intoreact-native-maps:masterfrom ochanje210:master
spikebrehm merged 5 commits intoreact-native-maps:masterfrom
ochanje210:master
Conversation
|
Lgtm! |
| loadingBackgroundColor={"#eeeeee"} | ||
| loadingIndicatorColor={'#666666'} | ||
| loadingBackgroundColor={'#eeeeee'} | ||
| > |
Collaborator
There was a problem hiding this comment.
I think double quotes is desired for JSX. Can probably get rid of the curly braces.
Contributor
Author
There was a problem hiding this comment.
I appreciate your advise. I changed back to double quotes and removed curly braces
| loadingBackgroundColor={"#eeeeee"} | ||
| loadingIndicatorColor={'#666666'} | ||
| loadingBackgroundColor={'#eeeeee'} | ||
| > |
Collaborator
There was a problem hiding this comment.
See comment above.
Contributor
Author
There was a problem hiding this comment.
Same as comment above
|
Thank you! |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
included MapUrlTile usage in README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.