Fixes #470. Support legalLabelInsets on Apple Maps#840
Fixes #470. Support legalLabelInsets on Apple Maps#840gilbox merged 4 commits intoreact-native-maps:masterfrom
Conversation
This will add support for `legalLabelInsets` prop on iOS with Apple Maps. Code is adapted from RN core.
|
Thanks! We should probably avoid |
|
@gilbox Yeah, let's keep it consistent. I've removed it. |
|
@scarlac will you be able to add an example? |
|
@gilbox Ah! I am assuming you mean updating the documentation. Yes, I'll get right on it tomorrow and update this PR :) |
|
@scarlac I was talking about adding an example in the |
|
@gilbox I've added an example to demonstrate the usefulness of the Let me know if there's more you need before it's ready for a merging. |
|
lgtm but I'd like to get a second opinion re: the async op |
|
thanks @scarlac ( ◠‿◠ ) |
|
My pleasure! 👍 |
…eact-native-maps#840) * Fixes react-native-maps#470 for iOS and Apple Maps This will add support for `legalLabelInsets` prop on iOS with Apple Maps. Code is adapted from RN core. * Pluralize updateLegalLabelInset(s) for consistency * Removed arrow notation * Added legalLabelInsets example
…eact-native-maps#840) * Fixes react-native-maps#470 for iOS and Apple Maps This will add support for `legalLabelInsets` prop on iOS with Apple Maps. Code is adapted from RN core. * Pluralize updateLegalLabelInset(s) for consistency * Removed arrow notation * Added legalLabelInsets example
Fixes #470. This will add support for
legalLabelInsetsprop on iOS with Apple Maps. Code is adapted from RN core.