[android crash] Fix exception when animating region during initialization#901
Merged
christopherdro merged 1 commit intoreact-native-maps:masterfrom Dec 27, 2016
Conversation
Contributor
Author
|
cc: @spikebrehm |
|
Released as v0.12.3 |
pinpong
pushed a commit
to pinpong/react-native-maps
that referenced
this pull request
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash cause by calling animateToRegion on the map while it is still be initialized.
To reproduce:
In the
componentDidMountof the component that renders theMapViewadd athis._map.animateToRegion(region, 1500);.Basically on the native side we haven't initialized the
mapvariable yet (which happens inonMapReady) so if that's the case we can't do ananimateToRegionyet.