-
Notifications
You must be signed in to change notification settings - Fork 748
Open
Description
I've been having a try with the Brush component and noticed that the margin does not have any effect on the Brush area or calculations. Even looking at the Brush-Demo you can see that the const brushMargin = { top: 10, bottom: 15, left: 50, right: 20 }; is not moving anytihing inside the <rect /> for the brush but instead is being used only by the <g /> element for the <ChartArea />
This is a bit problematic and forces you to wrap the charts in a <g /> in order to correctly align them rather then being able to build the scale using margin.left and innerWidth like is sometimes common with D3 patterns.
To Recreate
- open the demo in CodeSandbox
- Go to
line 189margin={brushMargin} - Delete the
marginprop from the<Brush /> - See nothing change in the brush 🤷
DimaKoshevoy, RyKilleen, benvp, PatriceHerstix, nd-novorender and 3 more
Metadata
Metadata
Assignees
Labels
No labels