Skip to content

ci: add environment declaration for DockerhHub publish #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aaron ("AJ") Steers (aaronsteers) merged 4 commits into from
Nov 20, 2024
Merged

ci: add environment declaration for DockerhHub publish #78

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1e02f0a
add comment explaining workflow, add environment declaration for Dock…
aaronsteers Nov 20, 2024
1c380c7
remove 'v' prefix in docker image tag
aaronsteers Nov 20, 2024
49f8b93
fix refs
aaronsteers Nov 20, 2024
16f294a
update variable handling logic
aaronsteers Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions .github/workflows/pypi_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# This workflow builds the python package.
# On release tags, it also publishes to PyPI and DockerHub.
# If we rename the workflow file name, we have to also update the
# Trusted Publisher settings on PyPI.
name: Packaging and Publishing

on:
Expand Down Expand Up @@ -61,6 +65,9 @@ jobs:
if: startsWith(github.ref, 'refs/tags/v') || github.event_name == 'workflow_dispatch'
runs-on: ubuntu-latest
needs: [publish]
environment:
name: DockerHub
url: https://hub.docker.com/r/airbyte/source-declarative-manifest/tags

steps:
- uses: actions/checkout@v4
Expand All @@ -70,14 +77,22 @@ jobs:
- name: Set Version (workflow_dispatch)
if: github.event_name == 'workflow_dispatch'
run: |
echo "Version set to ${{ github.event.inputs.version }}"
echo "VERSION=${{ github.event.inputs.version }}" >> $GITHUB_ENV
VERSION=${{ github.event.inputs.version }}
echo "Version input set to '${VERSION}'"
# Remove the 'v' prefix if it exists
VERSION=${VERSION#v}
echo "Setting version to '$VERSION'"
echo "VERSION=${VERSION}" >> $GITHUB_ENV

- name: Set Version (tag)
if: startsWith(github.ref, 'refs/tags/v')
run: |
echo "Version set to ${{ github.ref_name }}"
echo "VERSION=${{ github.ref_name }}" >> $GITHUB_ENV
VERSION=${{ github.ref_name }}
echo "Version ref set to '${VERSION}'"
# Remove the 'v' prefix if it exists
VERSION=${VERSION#v}
echo "Setting version to '$VERSION'"
echo "VERSION=${VERSION}" >> $GITHUB_ENV

# We need to download the build artifact again because the previous job was on a different runner
- name: Download Build Artifact
Expand Down