This repository was archived by the owner on Jun 30, 2022. It is now read-only.
Commit b382f7a
authored
Fix recursive locking when running with
Apparently, the buffering of the response body introduced in #14 causes Rack to fail with a recursive-lock exception when running with `config.allow_concurrency = false`. Unclear why this happens.
This reverts the buffering of the response body, though we now appear to be doing precisely what the Rack specification advises against: "Middleware must not call `each` directly on the Body. Instead, middleware can return a new Body that calls `each` on the original Body, yielding at least once per iteration." (https://github.com/rack/rack/blob/d15dd728440710cfc35ed155d66a98dc2c07ae42/SPEC.rdoc#the-body-)
Bumped to 0.2.14.config.allow_concurrency = false (#17)1 parent e99f9dc commit b382f7a
3 files changed
+3
-13
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | 58 | | |
62 | 59 | | |
63 | 60 | | |
| |||
74 | 71 | | |
75 | 72 | | |
76 | 73 | | |
77 | | - | |
| 74 | + | |
78 | 75 | | |
79 | 76 | | |
80 | 77 | | |
81 | 78 | | |
82 | 79 | | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | 80 | | |
91 | 81 | | |
92 | 82 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
0 commit comments