Merge pull request humanitec-architecture#2 from htc-demo-27/fixGHappCreation

johanneswuerbach · web-flow · commit dbf56c0f41a7 · 2023-10-09T14:21:24.000+02:00
Moved log output to correct scope for used const
diff --git a/examples/with-backstage/create-gh-app/index.js b/examples/with-backstage/create-gh-app/index.js
@@ -91,6 +91,8 @@ const writeConfigFile = async (data, webhookUrl) => {
   }, null, 2)
 
   await fs.writeFile(fileName, content);
+
+  console.log(`Created ${fileName}, you can close the server now.`)
 }
 
 const handleCallback = async (req, res) => {
@@ -109,8 +111,6 @@ const handleCallback = async (req, res) => {
 
   await writeConfigFile(data, webhookUrl);
 
-  console.log(`Created ${fileName}, you can close the server now.`)
-
   res.writeHead(302, { Location: `${data.html_url}/installations/new` });
   res.end();
 }

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,8 @@ const writeConfigFile = async (data, webhookUrl) => {`
`91`	`91`	`}, null, 2)`
`92`	`92`
`93`	`93`	`await fs.writeFile(fileName, content);`
	`94`	`+`
	`95`	+ console.log(`Created ${fileName}, you can close the server now.`)
`94`	`96`	`}`
`95`	`97`
`96`	`98`	`const handleCallback = async (req, res) => {`
`@@ -109,8 +111,6 @@ const handleCallback = async (req, res) => {`
`109`	`111`
`110`	`112`	`await writeConfigFile(data, webhookUrl);`
`111`	`113`
`112`		- console.log(`Created ${fileName}, you can close the server now.`)
`113`		`-`
`114`	`114`	res.writeHead(302, { Location: `${data.html_url}/installations/new` });
`115`	`115`	`res.end();`
`116`	`116`	`}`