Skip to content

Commit efb03d9

Browse files
Perform PR build test (#6788)
* Change test * Update .github/workflows/lint.yaml Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev> * Fix all --------- Co-authored-by: Daniel Rozenberg <rodaniel@amp.dev>
1 parent e28233f commit efb03d9

File tree

8 files changed

+58
-74
lines changed

8 files changed

+58
-74
lines changed

.github/workflows/lint-yaml.yaml

Lines changed: 0 additions & 29 deletions
This file was deleted.
Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
11
---
2-
name: 'Lint: JavaScript'
2+
name: 'Lint: all'
33

44
on:
55
workflow_dispatch:
66
push:
7-
paths:
8-
- '**/*.js'
7+
branches:
8+
- main
9+
pull_request:
10+
911
jobs:
1012
test:
1113
runs-on: ubuntu-latest
@@ -22,6 +24,8 @@ jobs:
2224
- name: Installing Node.js packages
2325
run: npm ci
2426

27+
- name: Linting YAML files
28+
run: gulp lintYaml
29+
2530
- name: Linting JavaScript files
26-
run: |
27-
gulp lintNode
31+
run: gulp lintNode

.github/workflows/test-default.yaml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/workflows/test-platform.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ name: 'Test: Platform'
44
on:
55
workflow_dispatch:
66
push:
7-
paths:
8-
- 'package.json'
9-
- 'platform/lib/**'
7+
branches:
8+
- main
9+
pull_request:
1010

1111
jobs:
1212
test:

.github/workflows/test-playground.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ name: 'Test: Playground'
44
on:
55
workflow_dispatch:
66
push:
7-
paths:
8-
- 'package.json'
9-
- 'playground/**'
7+
branches:
8+
- main
9+
pull_request:
1010

1111
jobs:
1212
test:

package-lock.json

Lines changed: 32 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@
3838
"_test:pixi:e2e": "APP_ENV=local jest --forceExit -c e2e.jest.config.js",
3939
"test:grow-extensions": "cd pages/extensions && if which grow; then python3 -m unittest discover -p \"*_test.py\"; else echo grow not installed with pip. skip tests; fi"
4040
},
41-
"keywords": ["amphtml", "framework", "documentation"],
41+
"keywords": [
42+
"amphtml",
43+
"framework",
44+
"documentation"
45+
],
4246
"author": "The AMP HTML Authors",
4347
"license": "Apache-2.0",
4448
"signale": {
@@ -49,7 +53,10 @@
4953
"@boilerplate": "boilerplate",
5054
"@lib": "platform/lib"
5155
},
52-
"browserslist": ["last 2 versions", "not dead"],
56+
"browserslist": [
57+
"last 2 versions",
58+
"not dead"
59+
],
5360
"dependencies": {
5461
"@ampproject/toolbox-cache-list": "2.9.0",
5562
"@ampproject/toolbox-cors": "2.9.0",
@@ -115,7 +122,7 @@
115122
"@rollup/plugin-node-resolve": "15.2.3",
116123
"@rollup/plugin-replace": "5.0.5",
117124
"absolutify": "0.1.0",
118-
"amphtml-validator": "1.0.35",
125+
"amphtml-validator": "1.0.38",
119126
"ansi-colors": "4.1.3",
120127
"archiver": "6.0.1",
121128
"babel-loader": "9.1.3",

playground/src/validator/validator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import events from '../events/events.js';
1717
import lazyLoad from '../lazy-load/base.js';
1818
import {EVENT_SET_RUNTIME} from '../runtime/runtimes.js';
1919

20-
const DEFAULT_VALIDATOR_URL = 'https://ampjs.org/v0/validator_wasm.js';
20+
const DEFAULT_VALIDATOR_URL = 'https://cdn.ampproject.org/v0/validator_wasm.js';
2121

2222
export const NO_ERRORS = {
2323
errors: [],

0 commit comments

Comments
 (0)