test: add circleci sharding to bazel e2e tests

Author: jbedard

.circleci/dynamic_config.yml

@@ -347,6 +347,7 @@ jobs:
 
   bazel-e2e-tests:
     executor: bazel-executor
+    parallelism: 2
     parameters:
       build_type:
         type: enum
@@ -364,7 +365,7 @@ jobs:
       - run: mkdir /mnt/ramdisk/e2e
       - run:
           name: Test << parameters.build_type >> << parameters.subset >>
-          command: yarn bazel test --define=E2E_TEMP=/mnt/ramdisk/e2e --config=<< parameters.build_type >> //tests/legacy-cli:e2e.<< parameters.subset >>
+          command: yarn bazel test --define=E2E_TEMP=/mnt/ramdisk/e2e --define=E2E_SHARD_TOTAL=${CIRCLE_NODE_TOTAL} --define=E2E_SHARD=${CIRCLE_NODE_INDEX} --config=<< parameters.build_type >> //tests/legacy-cli:e2e.<< parameters.subset >>
           no_output_timeout: 40m
       - store_artifacts:
           path: dist/testlogs/tests/legacy-cli/e2e.<< parameters.subset >>

tests/legacy-cli/e2e.bzl

@@ -78,7 +78,7 @@ def _e2e_tests(name, runner, **kwargs):
     tags = kwargs.pop("tags", []) + TEST_TAGS
 
     # Passthru E2E variables in case it is customized by CI etc
-    configuration_env_vars = kwargs.pop("configuration_env_vars", []) + ["E2E_TEMP"]
+    configuration_env_vars = kwargs.pop("configuration_env_vars", []) + ["E2E_TEMP", "E2E_SHARD_INDEX", "E2E_SHARD_TOTAL"]
 
     env = kwargs.pop("env", {})
 

tests/legacy-cli/e2e_runner.ts

@@ -65,11 +65,18 @@ const argv = yargsParser(process.argv.slice(2), {
 
     'debug': !!process.env.BUILD_WORKSPACE_DIRECTORY,
     'glob': process.env.TESTBRIDGE_TEST_ONLY,
-    'nb-shards': process.env.TEST_TOTAL_SHARDS,
-    'shard': process.env.TEST_SHARD_INDEX,
+    'nb-shards':
+      Number(process.env.E2E_SHARD_TOTAL ?? 1) * Number(process.env.TEST_TOTAL_SHARDS ?? 1) || 1,
+    'shard':
+      process.env.E2E_SHARD_INDEX === undefined && process.env.TEST_SHARD_INDEX === undefined
+        ? undefined
+        : Number(process.env.E2E_SHARD_INDEX ?? 0) * Number(process.env.E2E_SHARD_TOTAL ?? 1) +
+          Number(process.env.TEST_SHARD_INDEX ?? 0),
   },
 });
 
+console.log(argv);
+
 /**
  * Set the error code of the process to 255.  This is to ensure that if something forces node
  * to exit without finishing properly, the error code will be 255. Right now that code is not used.
@@ -145,8 +152,8 @@ const allTests = glob
   })
   .sort();
 
-const shardId = 'shard' in argv ? Number(argv['shard']) : null;;
-const nbShards = (shardId === null) ? 1 : Number(argv['nb-shards']);
+const shardId = argv['shard'] !== undefined ? Number(argv['shard']) : null;
+const nbShards = shardId === null ? 1 : Number(argv['nb-shards']);
 const tests = allTests.filter((name) => {
   // Check for naming tests on command line.
   if (argv._.length == 0) {
@@ -170,7 +177,6 @@ if (testsToRun.length === 0) {
     console.log(`No tests to run on shard ${shardId}, exiting.`);
     process.exit(0);
   } else {
-    console.log(`No tests would be ran, aborting.`);
     process.exit(1);
   }
 }