fixup! test: catch and log all errors include test setup

Author: jbedard

tests/legacy-cli/e2e_runner.ts

@@ -175,22 +175,13 @@ Promise.all([findFreePort(), findFreePort()])
       await runSteps(runSetup, allSetups, 'setup');
       await runSteps(runInitializer, allInitializers, 'initializer');
       await runSteps(runTest, testsToRun, 'test');
-    } finally {
-      registryProcess.kill();
-      secureRegistryProcess.kill();
-    }
-  })
-  .then(
-    () => {
+
       if (shardId !== null) {
         console.log(colors.green(`Done shard ${shardId} of ${nbShards}.`));
       } else {
         console.log(colors.green('Done.'));
       }
-
-      process.exit(0);
-    },
-    (err) => {
+    } catch (err) {
       if (err instanceof Error) {
         console.log('\n');
         console.error(colors.red(err.message));
@@ -211,9 +202,16 @@ Promise.all([findFreePort(), findFreePort()])
         }
       }
 
-      process.exit(1);
-    },
-  );
+      process.exitCode = 1;
+    } finally {
+      registryProcess.kill();
+      secureRegistryProcess.kill();
+    }
+  })
+  .catch((err) => {
+    console.error(colors.red(`Unkown Error: ${err}`));
+    process.exitCode = 1;
+  });
 
 async function runSteps(
   run: (name: string) => Promise<void> | void,