test: do not depend on a global npm binary

Author: jbedard

package.json

@@ -171,6 +171,7 @@
     "minimatch": "5.1.0",
     "ng-packagr": "14.0.0",
     "node-fetch": "^2.2.0",
+    "npm": "^8.11.0",
     "npm-package-arg": "9.0.2",
     "open": "8.4.0",
     "ora": "5.4.1",

tests/legacy-cli/e2e/setup/010-local-publish.ts

@@ -1,11 +1,10 @@
 import { getGlobalVariable } from '../utils/env';
-import { execWithEnv, extractNpmEnv } from '../utils/process';
+import { globalNpm, extractNpmEnv } from '../utils/process';
 import { isPrereleaseCli } from '../utils/project';
 
 export default async function () {
   const testRegistry: string = getGlobalVariable('package-registry');
-  await execWithEnv(
-    'npm',
+  await globalNpm(
     [
       'run',
       'admin',

tests/legacy-cli/e2e/setup/100-global-cli.ts

@@ -1,5 +1,5 @@
 import { getGlobalVariable } from '../utils/env';
-import { silentNpm } from '../utils/process';
+import { globalNpm } from '../utils/process';
 
 const NPM_VERSION = '7.24.0';
 const YARN_VERSION = '1.22.18';
@@ -13,12 +13,12 @@ export default async function () {
   const testRegistry: string = getGlobalVariable('package-registry');
 
   // Install global Angular CLI being tested, npm+yarn used by e2e tests.
-  await silentNpm(
+  await globalNpm([
     'install',
     '--global',
     `--registry=${testRegistry}`,
     '@angular/cli',
     `npm@${NPM_VERSION}`,
     `yarn@${YARN_VERSION}`,
-  );
+  ]);
 }

tests/legacy-cli/e2e/utils/BUILD.bazel

@@ -14,6 +14,7 @@ ts_library(
         "@npm//@types/yargs-parser",
         "@npm//ansi-colors",
         "@npm//glob",
+        "@npm//npm",
         "@npm//protractor",
         "@npm//puppeteer",
         "@npm//rxjs",

tests/legacy-cli/e2e/utils/process.ts

@@ -322,6 +322,16 @@ export function silentYarn(...args: string[]) {
   return _exec({ silent: true }, 'yarn', args);
 }
 
+export function globalNpm(args: string[], env?: NodeJS.ProcessEnv) {
+  if (!process.env.LEGACY_CLI_RUNNER) {
+    throw new Error(
+      'The global npm cli should only be executed from the primary e2e runner process',
+    );
+  }
+
+  return _exec({ silent: true, env }, 'node', [require.resolve('npm'), ...args]);
+}
+
 export function npm(...args: string[]) {
   return _exec({}, 'npm', args);
 }

tests/legacy-cli/e2e_runner.ts

@@ -55,6 +55,11 @@ const argv = yargsParser(process.argv.slice(2), {
  */
 process.exitCode = 255;
 
+/**
+ * Mark this process as the main e2e_runner
+ */
+process.env.LEGACY_CLI_RUNNER = '1';
+
 const logger = createConsoleLogger(argv.verbose, process.stdout, process.stderr, {
   info: (s) => s,
   debug: (s) => s,