test: remove no longer needed delay in code coverage tests

This should no longer needed as the root issue has been addressed upstream.

Author: alan-agius4

packages/angular_devkit/build_angular/src/builders/karma/tests/behavior/code-coverage_spec.ts

@@ -8,18 +8,9 @@
 
 import { tags } from '@angular-devkit/core';
 import { last, tap } from 'rxjs/operators';
-import { promisify } from 'util';
 import { execute } from '../../index';
 import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeBuilder } from '../setup';
 
-// In each of the test below we'll have to call setTimeout to wait for the coverage
-// analysis to be done. This is because karma-coverage performs the analysis
-// asynchronously but the promise that it returns is not awaited by Karma.
-// Coverage analysis begins when onRunComplete() is invoked, and output files
-// are subsequently written to disk. For more information, see
-// https://github.com/karma-runner/karma-coverage/blob/32acafa90ed621abd1df730edb44ae55a4009c2c/lib/reporter.js#L221
-
-const setTimeoutPromise = promisify(setTimeout);
 const coveragePath = 'coverage/lcov.info';
 
 describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
@@ -36,7 +27,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).toExist();
     });
 
@@ -95,7 +85,7 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
           `title = 'app'`,
           tags.stripIndents`
           title = 'app';
-  
+
           async foo() {
             return 'foo';
           }
@@ -111,8 +101,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
-
       harness
         .expectFile('coverage/app.component.ts.html')
         .content.toContain(

packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage-exclude_spec.ts

@@ -6,18 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import { promisify } from 'util';
 import { execute } from '../../index';
 import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeBuilder } from '../setup';
 
-// In each of the test below we'll have to call setTimeout to wait for the coverage
-// analysis to be done. This is because karma-coverage performs the analysis
-// asynchronously but the promise that it returns is not awaited by Karma.
-// Coverage analysis begins when onRunComplete() is invoked, and output files
-// are subsequently written to disk. For more information, see
-// https://github.com/karma-runner/karma-coverage/blob/32acafa90ed621abd1df730edb44ae55a4009c2c/lib/reporter.js#L221
-
-const setTimeoutPromise = promisify(setTimeout);
 const coveragePath = 'coverage/lcov.info';
 
 describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
@@ -33,7 +24,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
 
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).content.not.toContain('app.component.ts');
     });
 
@@ -48,7 +38,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
 
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).content.not.toContain('app.component.ts');
     });
 
@@ -62,7 +51,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
 
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).content.toContain('app.component.ts');
     });
   });

packages/angular_devkit/build_angular/src/builders/karma/tests/options/code-coverage_spec.ts

@@ -6,18 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import { promisify } from 'util';
 import { execute } from '../../index';
 import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeBuilder } from '../setup';
 
-// In each of the test below we'll have to call setTimeout to wait for the coverage
-// analysis to be done. This is because karma-coverage performs the analysis
-// asynchronously but the promise that it returns is not awaited by Karma.
-// Coverage analysis begins when onRunComplete() is invoked, and output files
-// are subsequently written to disk. For more information, see
-// https://github.com/karma-runner/karma-coverage/blob/32acafa90ed621abd1df730edb44ae55a4009c2c/lib/reporter.js#L221
-
-const setTimeoutPromise = promisify(setTimeout);
 const coveragePath = 'coverage/lcov.info';
 
 describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
@@ -31,7 +22,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).toExist();
     });
 
@@ -44,8 +34,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
 
       expect(result?.success).toBeTrue();
-
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).toNotExist();
     });
 
@@ -57,8 +45,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
 
       expect(result?.success).toBeTrue();
-
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).toNotExist();
     });
 
@@ -73,7 +59,7 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
         './src/app/app.component.ts': `
           import { Component } from '@angular/core';
           import { title } from 'my-lib';
-  
+
           @Component({
             selector: 'app-root',
             templateUrl: './app.component.html',
@@ -105,7 +91,6 @@ describeBuilder(execute, KARMA_BUILDER_INFO, (harness) => {
       const { result } = await harness.executeOnce();
       expect(result?.success).toBeTrue();
 
-      await setTimeoutPromise(1000);
       harness.expectFile(coveragePath).content.not.toContain('my-lib');
     });
   });