test: use tree-kill callback

tree-kill kills process asynchronously, but previously we didn't wait for the processes to be terminated before we continue running other tests.

With this change we use the tree-kill callback method to wait for the processes to be killed before we continue with out tests.

Author: alan-agius4

tests/legacy-cli/e2e/tests/basic/e2e.ts

@@ -66,12 +66,6 @@ export default function () {
           ng('e2e', 'test-project', '--no-webdriver-update', '--dev-server-target='),
         ),
       )
-      .then(
-        () => killAllProcesses(),
-        (err) => {
-          killAllProcesses();
-          throw err;
-        },
-      )
+      .finally(() => killAllProcesses())
   );
 }

tests/legacy-cli/e2e/tests/basic/rebuild.ts

@@ -181,12 +181,6 @@ export default function () {
           throw new Error('Expected component CSS to update.');
         }
       })
-      .then(
-        () => killAllProcesses(),
-        (err: unknown) => {
-          killAllProcesses();
-          throw err;
-        },
-      )
+      .finally(() => killAllProcesses())
   );
 }

tests/legacy-cli/e2e/tests/basic/serve.ts

@@ -7,13 +7,13 @@ export default async function () {
     // Serve works without HMR
     await ngServe('--no-hmr');
     await verifyResponse();
-    killAllProcesses();
+    await killAllProcesses();
 
     // Serve works with HMR
     await ngServe('--hmr');
     await verifyResponse();
   } finally {
-    killAllProcesses();
+    await killAllProcesses();
   }
 }
 

tests/legacy-cli/e2e/tests/build/poll.ts

@@ -24,6 +24,6 @@ export default async function () {
     // But a rebuild should happen roughly within the 10 second window.
     await waitForAnyProcessOutputToMatch(webpackGoodRegEx, 7000);
   } finally {
-    killAllProcesses();
+    await killAllProcesses();
   }
 }

tests/legacy-cli/e2e/tests/build/rebuild-deps-type-check.ts

@@ -114,12 +114,6 @@ export default function () {
           throw new Error('Expected no error but an error was shown.');
         }
       })
-      .then(
-        () => killAllProcesses(),
-        (err: any) => {
-          killAllProcesses();
-          throw err;
-        },
-      )
+      .finally(() => killAllProcesses())
   );
 }

tests/legacy-cli/e2e/tests/build/rebuild-replacements.ts

@@ -13,7 +13,6 @@ export default async function () {
     return;
   }
 
-  let error;
   try {
     await execAndWaitForOutputToMatch(
       'ng',
@@ -26,12 +25,7 @@ export default async function () {
     // Should trigger a rebuild.
     await appendToFile('src/environments/environment.prod.ts', `console.log('PROD');`);
     await waitForAnyProcessOutputToMatch(webpackGoodRegEx, 45000);
-  } catch (e) {
-    error = e;
-  }
-
-  killAllProcesses();
-  if (error) {
-    throw error;
+  } finally {
+    await killAllProcesses();
   }
 }

tests/legacy-cli/e2e/tests/build/rebuild-types.ts

@@ -26,6 +26,6 @@ export default async function () {
       writeFile('src/app/type.ts', `export type MyType = string;`),
     ]);
   } finally {
-    killAllProcesses();
+    await killAllProcesses();
   }
 }

tests/legacy-cli/e2e/tests/commands/serve/reload-shims.ts

@@ -20,6 +20,6 @@ export default async function () {
       /Module not found: Error: Can't resolve 'path'/,
     );
   } finally {
-    killAllProcesses();
+    await killAllProcesses();
   }
 }

tests/legacy-cli/e2e/tests/commands/serve/serve-path.ts

@@ -18,20 +18,5 @@ export default function () {
       assert.strictEqual(response.status, 200);
       assert.match(await response.text(), /<app-root><\/app-root>/);
     })
-    .then(
-      () => killAllProcesses(),
-      (err) => {
-        killAllProcesses();
-        throw err;
-      },
-    );
-  // .then(() => ngServe('--base-href', 'test/'))
-  // .then((response) => response.text())
-  // .then(() => fetch('http://localhost:4200/test', { headers: { 'Accept': 'text/html' } }))
-  // .then(body => {
-  //   if (!body.match(/<app-root><\/app-root>/)) {
-  //     throw new Error('Response does not match expected value.');
-  //   }
-  // })
-  // .then(() => killAllProcesses(), (err) => { killAllProcesses(); throw err; });
+    .finally(() => killAllProcesses());
 }

tests/legacy-cli/e2e/tests/misc/ask-missing-builder.ts

@@ -14,7 +14,7 @@ export default async function () {
       /Would you like to add a package with "deploy" capabilities/,
     );
 
-    killAllProcesses();
+    await killAllProcesses();
 
     // Execute a command with TTY force enabled
     execWithEnv('ng', ['lint'], {
@@ -26,6 +26,6 @@ export default async function () {
     // Check if the prompt is shown
     await waitForAnyProcessOutputToMatch(/Would you like to add ESLint now/);
   } finally {
-    killAllProcesses();
+    await killAllProcesses();
   }
 }