build: fix typescript compilation errors

Author: jbedard

tests/legacy-cli/e2e/setup/010-local-publish.ts

@@ -3,7 +3,7 @@ import { execWithEnv, extractNpmEnv } from '../utils/process';
 import { isPrereleaseCli } from '../utils/project';
 
 export default async function () {
-  const testRegistry = getGlobalVariable('package-registry');
+  const testRegistry: string = getGlobalVariable('package-registry');
   await execWithEnv(
     'npm',
     [

tests/legacy-cli/e2e/setup/100-global-cli.ts

@@ -7,7 +7,7 @@ export default async function () {
     return;
   }
 
-  const testRegistry = getGlobalVariable('package-registry');
+  const testRegistry: string = getGlobalVariable('package-registry');
 
   // Install global Angular CLI.
   await silentNpm('install', '--global', '@angular/cli', `--registry=${testRegistry}`);

tests/legacy-cli/e2e/setup/300-log-environment.ts

@@ -10,7 +10,7 @@ export default async function () {
       return;
     }
 
-    console.log(`  ${envName}: ${process.env[envName].replace(/[\n\r]+/g, '\n        ')}`);
+    console.log(`  ${envName}: ${process.env[envName]!.replace(/[\n\r]+/g, '\n        ')}`);
   });
 
   await node('--version');

tests/legacy-cli/e2e/setup/500-create-project.ts

@@ -17,12 +17,10 @@ export default async function () {
     process.chdir(argv.reuse);
     await gitClean();
   } else {
-    const extraArgs = [];
-
     // Ensure local test registry is used when outside a project
     await setNPMConfigRegistry(true);
 
-    await ng('new', 'test-project', '--skip-install', ...extraArgs);
+    await ng('new', 'test-project', '--skip-install');
     await expectFileToExist(join(process.cwd(), 'test-project'));
     process.chdir('./test-project');
 

tests/legacy-cli/e2e/tests/build/build-app-shell-with-schematic.ts

@@ -12,11 +12,13 @@ export default async function () {
 
   const isSnapshotBuild = getGlobalVariable('argv')['ng-snapshots'];
   if (isSnapshotBuild) {
-    const packagesToInstall = [];
+    const packagesToInstall: string[] = [];
     await updateJsonFile('package.json', (packageJson) => {
       const dependencies = packageJson['dependencies'];
       // Iterate over all of the packages to update them to the snapshot version.
-      for (const [name, version] of Object.entries(snapshots.dependencies)) {
+      for (const [name, version] of Object.entries(
+        snapshots.dependencies as { [p: string]: string },
+      )) {
         if (name in dependencies && dependencies[name] !== version) {
           packagesToInstall.push(version);
         }

tests/legacy-cli/e2e/tests/build/platform-server.ts

@@ -12,11 +12,11 @@ export default async function () {
 
   const isSnapshotBuild = getGlobalVariable('argv')['ng-snapshots'];
   if (isSnapshotBuild) {
-    const packagesToInstall = [];
+    const packagesToInstall: string[] = [];
     await updateJsonFile('package.json', (packageJson) => {
       const dependencies = packageJson['dependencies'];
       // Iterate over all of the packages to update them to the snapshot version.
-      for (const [name, version] of Object.entries(snapshots.dependencies)) {
+      for (const [name, version] of Object.entries<string>(snapshots.dependencies)) {
         if (name in dependencies && dependencies[name] !== version) {
           packagesToInstall.push(version);
         }

tests/legacy-cli/e2e/tests/build/prod-build.ts

@@ -39,7 +39,7 @@ export default async function () {
   }
 
   const indexContent = await readFile('dist/test-project/index.html');
-  const mainPath = indexContent.match(/src="(main\.[0-9a-zA-Z]{0,32}\.js)"/)[1];
+  const mainPath = indexContent.match(/src="(main\.[0-9a-zA-Z]{0,32}\.js)"/)![1];
 
   // Content checks
   await expectFileToMatch(`dist/test-project/${mainPath}`, bootstrapRegExp);

tests/legacy-cli/e2e/tests/commands/add/add-pwa.ts

@@ -53,7 +53,8 @@ export default async function () {
 
   // It should correctly generate assetGroups and include at least one URL in each group.
   const ngswJson = JSON.parse(await readFile(ngswPath));
-  const assetGroups = ngswJson.assetGroups.map(({ name, urls }) => ({
+  // @ts-ignore
+  const assetGroups: any[] = ngswJson.assetGroups.map(({ name, urls }) => ({
     name,
     urlCount: urls.length,
   }));

tests/legacy-cli/e2e/tests/i18n/ivy-localize-basehref.ts

@@ -11,7 +11,7 @@ import { ng } from '../../utils/process';
 import { updateJsonFile } from '../../utils/project';
 import { externalServer, langTranslations, setupI18nConfig } from './setup';
 
-const baseHrefs = {
+const baseHrefs: { [l: string]: string } = {
   'en-US': '/en/',
   fr: '/fr-FR/',
   de: '',
@@ -59,7 +59,7 @@ export default async function () {
     await ng('e2e', `--configuration=${lang}`, '--port=0');
 
     // Execute Application E2E tests for a production build without dev server
-    const server = externalServer(outputPath, baseHrefs[lang] || '/');
+    const server = externalServer(outputPath, (baseHrefs[lang] as string) || '/');
     try {
       await ng(
         'e2e',

tests/legacy-cli/e2e/tests/i18n/ivy-localize-hashes.ts

@@ -27,7 +27,7 @@ export default async function () {
         continue;
       }
 
-      hashes.set(`${lang}/${match.groups.name}`, match.groups.hash);
+      hashes.set(`${lang}/${match!.groups!.name}`, match!.groups!.hash);
     }
   }
 
@@ -48,12 +48,12 @@ export default async function () {
         continue;
       }
 
-      const id = `${lang}/${match.groups.name}`;
+      const id = `${lang}/${match!.groups!.name}`;
       const hash = hashes.get(id);
       if (!hash) {
         throw new Error('Unexpected output entry: ' + id);
       }
-      if (hash === match.groups.hash) {
+      if (hash === match!.groups!.hash) {
         throw new Error('Hash value did not change for entry: ' + id);
       }