test(@ngtools/webpack): add source-map-support. - #7191
Conversation
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
filipesilva
left a comment
filipesilva
left a comment
There was a problem hiding this comment.
Can you also change the commit name to fix(@angular/cli): add explicit source-map-support dependency?
Commit messages affect the changelogs, and this change is for @angular/cli proper.
| "silent-error": "^1.0.0", | ||
| "source-map": "^0.5.6", | ||
| "source-map-loader": "^0.2.0", | ||
| "source-map-support": "^0.4.1", |
There was a problem hiding this comment.
Can you add this to https://github.com/angular/angular-cli/blob/master/packages/%40angular/cli/package.json as well?
We have several packages being deployed from the same repo so multiple package.json need to be updated.
There was a problem hiding this comment.
Dependency added and also fixed the enumerate in karma.ts.
|
I agree with the conclusions in pnpm/pnpm#863 and would like to see this merged. |
|
Done, thanks! |
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
…r#7191) karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree. pnpm/pnpm#863
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
karma plugin relies on source-map-support being a dependency of karma-source-map-support and npm 3+ flat dependency tree.
pnpm/pnpm#863