feat(@angular/cli): disable progress when running outside TTY - #8501
Merged
Conversation
The default value is changed from `true` to `progress.stdout.isTTY`. It still has lower priority than value specified by command line flag or in the .angular-cli.json config. Fixes angular#8148
devoto13
force-pushed
the
tty-no-progress
branch
from
November 17, 2017 18:32
2681fde to
428835e
Compare
filipesilva
approved these changes
Nov 20, 2017
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
This is a really nice feature, thanks!
devoto13
added a commit
to devoto13/angular-cli
that referenced
this pull request
Dec 18, 2017
…de TTY Fixes a shortcoming of angular#8501. Apply same logic for setting --progress flat when running Karma directly (as opposed to running it using `ng test` command). Fixes angular#8148
devoto13
added a commit
to devoto13/angular-cli
that referenced
this pull request
Dec 18, 2017
…de TTY Fixes a shortcoming of angular#8501. Apply same logic for setting --progress flag when running Karma directly (as opposed to running it using `ng test` command). Fixes angular#8148
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…de TTY Fixes a shortcoming of angular#8501. Apply same logic for setting --progress flag when running Karma directly (as opposed to running it using `ng test` command). Fixes angular#8148
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default value is changed from
truetoprogress.stdout.isTTY. Itstill has lower priority than value specified by command line flag or in
the .angular-cli.json config.
Fixes #8148
Not sure how to add a test though... Verified manually using: