From e929f9f272dec94bd74286f6c85726a28c0302f8 Mon Sep 17 00:00:00 2001 From: Jason Bedard Date: Wed, 24 Aug 2022 14:02:53 -0700 Subject: [PATCH 1/2] build: always set bazel nolegacy_external_runfiles to avoid busting analysis cache Use renamed experimental_allow_tags_propagation instead of previous name (incompatible_allow_tags_propagation). --- .bazelrc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.bazelrc b/.bazelrc index d5f02adbcdc8..e3fb14bdabf7 100644 --- a/.bazelrc +++ b/.bazelrc @@ -34,8 +34,7 @@ build --symlink_prefix=dist/ build --nowatchfs # Turn off legacy external runfiles -run --nolegacy_external_runfiles -test --nolegacy_external_runfiles +build --nolegacy_external_runfiles # Turn on --incompatible_strict_action_env which was on by default # in Bazel 0.21.0 but turned off again in 0.22.0. Follow @@ -51,7 +50,7 @@ test --incompatible_strict_action_env build --experimental_remote_merkle_tree_cache # Ensure that tags applied in BUILDs propagate to actions -build --incompatible_allow_tags_propagation +build --experimental_allow_tags_propagation # Don't check if output files have been modified build --noexperimental_check_output_files From 727e6337db1a7b927afdd4f550a72898fc59e271 Mon Sep 17 00:00:00 2001 From: Jason Bedard Date: Wed, 24 Aug 2022 16:38:17 -0700 Subject: [PATCH 2/2] build: allow no-remote-exec targets to be cached on CI --- .circleci/dynamic_config.yml | 8 -------- packages/angular_devkit/core/BUILD.bazel | 2 -- 2 files changed, 10 deletions(-) diff --git a/.circleci/dynamic_config.yml b/.circleci/dynamic_config.yml index 5b8a1fe733c9..e8b480e938b9 100644 --- a/.circleci/dynamic_config.yml +++ b/.circleci/dynamic_config.yml @@ -136,14 +136,6 @@ commands: # cause decryption failures based on the openssl version. https://stackoverflow.com/a/39641378/4317734 openssl aes-256-cbc -d -in .circleci/gcp_token -md md5 -k "${<< parameters.key >>}" -out /home/circleci/.gcp_credentials; sudo bash -c "echo -e 'build --google_credentials=/home/circleci/.gcp_credentials' >> .bazelrc.user"; - # Upload/don't upload local results to cache based on environment - if [[ -n "{$CIRCLE_PULL_REQUEST}" ]]; then - sudo bash -c "echo -e 'build:remote --remote_upload_local_results=false\n' >> .bazelrc.user"; - echo "Not uploading local build results to remote cache."; - else - sudo bash -c "echo -e 'build:remote --remote_upload_local_results=true\n' >> .bazelrc.user"; - echo "Uploading local build results to remote cache."; - fi # Enable remote builds sudo bash -c "echo -e 'build --config=remote' >> .bazelrc.user"; echo "Reading from remote cache for bazel remote jobs."; diff --git a/packages/angular_devkit/core/BUILD.bazel b/packages/angular_devkit/core/BUILD.bazel index 455df84160b8..a0a81a6837ad 100644 --- a/packages/angular_devkit/core/BUILD.bazel +++ b/packages/angular_devkit/core/BUILD.bazel @@ -70,8 +70,6 @@ ts_library( jasmine_node_test( name = "core_test_" + toolchain_name, srcs = [":core_test_lib"], - # TODO: Audit tests to determine if tests can be run in RBE environments - local = True, toolchain = toolchain, deps = [ # @node_module: ajv