File tree Expand file tree Collapse file tree 2 files changed +6
-9
lines changed
Expand file tree Collapse file tree 2 files changed +6
-9
lines changed Original file line number Diff line number Diff line change @@ -111,11 +111,6 @@ jobs:
111111 - name : Yarn install
112112 if : steps.node_modules_cache.outputs.cache-hit != 'true'
113113 run : yarn install --frozen-lockfile --prefer-offline
114- - name : Bump deps
115- run : |
116- yarn add firebase@${{ matrix.firebase }}
117- yarn add firebase-tools@${{ matrix.firebaseTools }}
118- yarn add rxjs@${{ matrix.rxjs }} --prefer-offline
119114 - name : Firebase emulator cache
120115 uses : actions/cache@v2
121116 with :
@@ -128,15 +123,15 @@ jobs:
128123 - name : Test Node
129124 run : |
130125 yarn build:jasmine
131- yarn test:node-esm
126+ yarn test:node
132127 - name : Test browser
128+ # only test on the default, maybe we should just make this a seperate test
133129 if : matrix.os == 'ubuntu-latest' && matrix.node == '16'
134130 run : yarn test:chrome-headless
135131 - name : ng-build yarn install
136132 run : |
137133 cd ./test/ng-build
138134 yarn --prefer-offline
139- yarn add firebase@${{ matrix.firebase }}
140135 - name : ng-build prerender
141136 run : |
142137 cd ./test/ng-build
@@ -213,7 +208,7 @@ jobs:
213208 - name : Test Node
214209 run : |
215210 yarn build:jasmine
216- yarn test:node-esm
211+ yarn test:node
217212 - name : Test browser
218213 run : yarn test:chrome-headless
219214 - name : ng-build yarn install
Original file line number Diff line number Diff line change @@ -630,7 +630,9 @@ describe('ng-add', () => {
630630 project : PROJECT_NAME ,
631631 prerender : false ,
632632 } ) ) . toBeRejectedWith (
633- new SchematicsException ( 'Error when parsing .firebaserc: Unexpected token I in JSON at position 0' )
633+ parseInt ( process . versions . node , 10 ) >= 20 ?
634+ new SchematicsException ( `Error when parsing .firebaserc: Unexpected token 'I', "I'm broken 😔" is not valid JSON.` ) :
635+ new SchematicsException ( 'Error when parsing .firebaserc: Unexpected token I in JSON at position 0' )
634636 ) ;
635637 } ) ;
636638
You can’t perform that action at this time.
0 commit comments