Feat(md-menu) : Added prevent close( when user clicks inside menu panel) feature#4354
Feat(md-menu) : Added prevent close( when user clicks inside menu panel) feature#4354ravinderpayal wants to merge 6 commits into
Conversation
Changed the on click callback methodto `_emitClickCloseEvent` as this method as an additional logic for checking if `preventClose` is asked or not.
satisfied travis-CI
satisfying travis-CI
|
👏 thanks |
|
@alexweber @alexeagle @agostinalucia @mprobst Why not reviewed yet? |
|
See @jelbourn's related comment here #4842 (comment) |
|
@ravinderpayal see #4842 for the discussion of why we do not want to add this feature. Also note that tagging a bunch of random Angular team members is the absolute worst way to get a PR reviewed. |
|
@jelbourn sorry sir, our team was in urgent need of |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |

As It's a feature the core team decided to add, and I was in need of this feature for functionality like drop-down menu having some setting controls where user may want to change multiple settings in one go. As currently after every click inside or outside of drop-down menu, it disappears. But adding some additional check based on the value of preventClose @input() supplied parent node can add this desired functionality. Actually I am creating a emoji picker, and have multiple categories of emoji, so user is required to change the category by clicking on tabs(Yeah I am using MD-tabs), menu disappears so this feature will help in accomplishing my specific requirement, and other people's similar requirements.