Merged
Conversation
tzemanovic
previously approved these changes
Feb 24, 2023
Collaborator
Author
|
I've updated this PR to set an upper-bound on the storage iterator given that there still were some undesired keys being dumped |
grarco
force-pushed
the
grarco/rocksdb-dump
branch
from
85518e0 to
e87efbb
Compare
Closed
tzemanovic
previously approved these changes
Mar 7, 2023
tzemanovic
reviewed
Mar 7, 2023
grarco
force-pushed
the
grarco/rocksdb-dump
branch
from
e87efbb to
d001d5b
Compare
tzemanovic
approved these changes
Mar 8, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 11, 2023
* grarco/rocksdb-dump: changelog: add #1184 Improves iterator in `dump-db` Updates RocksDB dump
Closed
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the
ledger dump-dbcommand. RocksDB iterator doesn't actually recognize the provided prefix correctly leading to duplicated keys in the dump file.This PR solves the duplicated keys issue and adds an
historicflag: if the flag is set it will dump thesubspacekeys and the diff of the last height, otherwise it will only dump thesubspacesubkeys.